Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sign: remove reg opts from sign blob #2512

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Dec 6, 2022

Signed-off-by: Asra Ali [email protected]

Summary

Release Note

Documentation

@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Merging #2512 (f8560b8) into main (6566619) will increase coverage by 0.59%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2512      +/-   ##
==========================================
+ Coverage   29.02%   29.62%   +0.59%     
==========================================
  Files         139      139              
  Lines        8559     8558       -1     
==========================================
+ Hits         2484     2535      +51     
+ Misses       5737     5666      -71     
- Partials      338      357      +19     
Impacted Files Coverage Δ
cmd/cosign/cli/options/signblob.go 0.00% <ø> (ø)
cmd/cosign/cli/sign/sign_blob.go 0.00% <0.00%> (ø)
cmd/cosign/cli/signblob.go 0.00% <0.00%> (ø)
pkg/blob/load.go 72.50% <0.00%> (+5.00%) ⬆️
pkg/oci/layout/index.go 28.57% <0.00%> (+28.57%) ⬆️
pkg/oci/layout/write.go 37.50% <0.00%> (+37.50%) ⬆️
pkg/oci/layout/signatures.go 53.84% <0.00%> (+53.84%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Asra Ali <[email protected]>

update lint

Signed-off-by: Asra Ali <[email protected]>

docgen

Signed-off-by: Asra Ali <[email protected]>

fix e2e test

Signed-off-by: Asra Ali <[email protected]>
@asraa
Copy link
Contributor Author

asraa commented Dec 6, 2022

I believe we don't need to make this a breaking change note, since it's in the CLI package.

@asraa asraa merged commit f7f7f3d into sigstore:main Dec 6, 2022
@github-actions github-actions bot added this to the v1.14.0 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants