Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ProjectSchedule] Add read-only variant, typing, tests #2414

Merged
merged 4 commits into from
Jul 25, 2023

Conversation

imnasnainaec
Copy link
Collaborator

@imnasnainaec imnasnainaec commented Jul 20, 2023

Closes #707


This change is Reviewable

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2023

Codecov Report

Patch coverage: 13.33% and project coverage change: +0.25% 🎉

Comparison is base (9ffd0a8) 67.70% compared to head (25ae15b) 67.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2414      +/-   ##
==========================================
+ Coverage   67.70%   67.95%   +0.25%     
==========================================
  Files         240      240              
  Lines        8254     8247       -7     
  Branches      504      505       +1     
==========================================
+ Hits         5588     5604      +16     
+ Misses       2308     2287      -21     
+ Partials      358      356       -2     
Flag Coverage Δ
backend 79.61% <ø> (-0.07%) ⬇️
frontend 54.35% <13.33%> (+0.59%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ojectSettings/ProjectSchedule/DateScheduleEdit.tsx 0.00% <0.00%> (ø)
...s/ProjectSettings/ProjectSchedule/DateSelector.tsx 0.00% <0.00%> (ø)
...rojectSettings/ProjectSchedule/ProjectSchedule.tsx 46.15% <0.00%> (+46.15%) ⬆️
src/components/ProjectSettings/index.tsx 69.56% <ø> (ø)
...s/ProjectSettings/ProjectSchedule/CalendarView.tsx 41.17% <66.66%> (+41.17%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@imnasnainaec imnasnainaec enabled auto-merge (squash) July 21, 2023 15:51
Copy link
Contributor

@jasonleenaylor jasonleenaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 9 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @imnasnainaec)

@imnasnainaec imnasnainaec merged commit 8ddbbd6 into master Jul 25, 2023
14 checks passed
@imnasnainaec imnasnainaec deleted the proj-settings-sched branch July 25, 2023 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ProjectSettings] Update visibility for non-owner users
3 participants