Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed cosmopower installation, test now skipped #87

Closed
wants to merge 5 commits into from

Conversation

itrharrison
Copy link
Collaborator

In order to address #86 more quickly so that we can run tests and continue dev work, this just removes the installation of cosmopower from the test env, meaning that the cosmopower tests are skipped when the CI is run.

@itrharrison itrharrison added bug Something isn't working tests Improvements to tests labels Nov 18, 2022
@itrharrison itrharrison self-assigned this Nov 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Merging #87 (0b0c81f) into master (b21cbc7) will decrease coverage by 2.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
- Coverage   76.00%   73.98%   -2.02%     
==========================================
  Files          29       29              
  Lines        1817     1822       +5     
==========================================
- Hits         1381     1348      -33     
- Misses        436      474      +38     
Impacted Files Coverage Δ
soliket/gaussian.py 69.73% <100.00%> (+0.40%) ⬆️
soliket/gaussian_data.py 87.00% <100.00%> (+0.54%) ⬆️
soliket/cosmopower.py 33.33% <0.00%> (-66.67%) ⬇️

@itrharrison itrharrison deleted the tests_remove_cosmopower branch March 3, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tests Improvements to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants