Add optional pisaDocument argument to set metadata #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistair-broomhead
force-pushed
the
feature/allow-setting-document-metadata
branch
from
82c88bf
to
43fe040
Compare
Without this the functionality of pisaDocument would need to be recreated in order to set metadata such as the document author.
alistair-broomhead
force-pushed
the
feature/allow-setting-document-metadata
branch
4 times, most recently
from
ffa2528
to
792bb8e
Compare
- Whether you specify metadata or not, a pdf should be created - When specifying metadata it should be what you set it to - When not specifying metadata it should not
alistair-broomhead
force-pushed
the
feature/allow-setting-document-metadata
branch
from
bed4f29
to
4aeaf0f
Compare
mayankamencherla
approved these changes
Dec 4, 2019
mayankamencherla
approved these changes
Dec 5, 2019
mayankamencherla
approved these changes
Dec 6, 2019
mayankamencherla
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this the functionality of pisaDocument would need to be
recreated in order to set metadata such as the document author.