Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional pisaDocument argument to set metadata #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add optional pisaDocument argument to set metadata #1

wants to merge 4 commits into from

Commits on Dec 15, 2015

  1. Add optional pisaDocument argument to set metadata 

    Without this the functionality of pisaDocument would need to be
recreated in order to set metadata such as the document author.
    @alistair-broomhead
    alistair-broomhead committed Dec 15, 2015
    Configuration menu
    Copy the full SHA
    735eb42 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2015

  1. Tests for adding document metadata 

     - Whether you specify metadata or not, a pdf should be created
 - When specifying metadata it should be what you set it to
 - When not specifying metadata it should not
    @alistair-broomhead
    alistair-broomhead committed Dec 18, 2015
    Configuration menu
    Copy the full SHA
    475fda8 View commit details
    Browse the repository at this point in the history

  2. Use correct nosetests

    @alistair-broomhead
    alistair-broomhead committed Dec 18, 2015
    Configuration menu
    Copy the full SHA
    4aeaf0f View commit details
    Browse the repository at this point in the history

  3. Simplify things by using BytesIO not pisaTempFile

    @alistair-broomhead
    alistair-broomhead committed Dec 18, 2015
    Configuration menu
    Copy the full SHA
    79c3c44 View commit details
    Browse the repository at this point in the history