Fix HTTP connection error for long running transfers #842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces an API for Skyplane Broadcast Todos: - [x] Fix provisioning in BroadcastDataplane - Reuse provision loop via inheritance - Move `_start_gateway` to a class method and override it - Adapt broadcast to use `bound_nodes` - [x] Add BroadcastCopyJob (ideally extend CopyJob) - [x] Update tracker to monitor broadcast jobs - [x] Add multipart support - [x] Fix dependency issue via adding dockerfile and bc_requirements - [x] Integrate with gateway and test the monitoring side Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Sarah Wooders <[email protected]>
…ct#829) Transferred to/from local paths needs to fall back on cloud provider tools until we provide full support for this. I cleaned up the `skyplane cp/sync` code to share a single function for shared logic for fallback options and initiating transfers.
simon-mo
approved these changes
May 15, 2023
| except Exception as e: | ||
| UsageClient.log_exception( | ||
| "dispatch job", | ||
| e, | ||
| args, | ||
| self.dataplane.topology.src_region_tag, | ||
| self.dataplane.topology.dest_region_tags, | ||
| self.dataplane.topology.dest_region_tags[0], # TODO: support multiple destinations |
There was a problem hiding this comment.
Suggested change
| self.dataplane.topology.dest_region_tags[0], # TODO: support multiple destinations | |
| *self.dataplane.topology.dest_region_tags, |
You can just "spread" this list as arguments
There was a problem hiding this comment.
what does this mean?
skyplane/api/transfer_job.py
Outdated
| headers={"Content-Type": "application/json"}, | ||
| ) | ||
| reply_json = json.loads(reply.data.decode("utf-8")) | ||
| print(server, min_idx, "added", n_added, len(chunk_batch), reply_json) |
There was a problem hiding this comment.
Suggested change
| print(server, min_idx, "added", n_added, len(chunk_batch), reply_json) |
| @@ -78,11 +78,14 @@ def worker_loop(self, worker_id: int, *args): | |||
| self.worker_id = worker_id | |||
| while not self.exit_flags[worker_id].is_set() and not self.error_event.is_set(): | |||
| try: | |||
| # print(f"[{self.handle}:{self.worker_id}] Waiting for chunk, queue size {self.input_queue.size()}") | |||
There was a problem hiding this comment.
clean up this file a bit?
| if chunk_req.chunk.chunk_length_bytes == 0: | ||
| # nothing to do | ||
| # create empty file | ||
| open(fpath, "a").close() |
There was a problem hiding this comment.
Path('path/to/file.txt').touch()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a few bug fixes causing errors for large transfers:
chunk_requestsPOST request will return how many chunks were added and the current queue size, informing the HTTP client making the request to send the remaining chunks (those not added) to a different gateway or to wait and try again. With this change, I was able to transfer 1TB.There are still issues for SSH connections for long running transfers, and listing files can take an extremely long time on the client (#841), so these issues need to be fixed to for very large transfers.