Added Dark Mode colors for default values #473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezathashim
commented
Feb 19, 2020
ezathashim
commented
- added code that checks for OS Version and adjusts default color to use System Colors for Dark Mode compatibility
|
👍 Thank for this improvements, did you test it already? could you please provide screenshots of your version? |
…use 'collectionView registerNib...' instead of 'registerClass' since my supplementary views are xib based.
skywinder
requested changes
Apr 29, 2020
| @@ -0,0 +1,8 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
There was a problem hiding this comment.
Please, remove changes in this file, since it's not related to this feature.
|
|
||
| if (@available(iOS 13.0, *)) { | ||
| self.titleTextAttributes = @{ NSForegroundColorAttributeName : UIColor.labelColor }; | ||
| } else { |
There was a problem hiding this comment.
why do you need empty else statement? I think we can easily delete them
| // Fallback on earlier versions | ||
| } | ||
| if (@available(iOS 13.0, *)) { | ||
| [self setTextColor: [UIColor labelColor]]; |
There was a problem hiding this comment.
you can make all this 3 set's in one
if (@available(iOS 13.0, *)) {
}
block. it would be easier to read.
|
Dear @ezathashim. I really appreciate your help. and thanks for support. But I would merge #479 since it already fixes all the issues that i mentioned above. Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.