Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Xcode 11.x compatibility & DarkMode support #479

Merged

Conversation

noorulain17
Copy link
Collaborator

@noorulain17 noorulain17 commented Apr 28, 2020

  • Added Xcode 11.x compatibility by adding AppIcon & LaunchScreen.storyboard

Screenshot 2020-04-28 at 2 12 14 PM

Screenshot 2020-04-28 at 1 24 45 PM

  • Added DarkMode support for iOS 13.x
    actionsheet

@skywinder
Copy link
Owner

Hello! thank you very much. Can you kindly check that cause merge conflicts in this branch?

@noorulain17
Copy link
Collaborator Author

Hello! thank you very much. Can you kindly check that cause merge conflicts in this branch?

Sure, checking now.
Thanks for your positive response :)

@noorulain17 noorulain17 force-pushed the added_Xcode_11.x_compatibility branch from ed199d3 to 2d4e098 Compare April 29, 2020 09:04
@noorulain17 noorulain17 force-pushed the added_Xcode_11.x_compatibility branch from 2d4e098 to 60fe02e Compare April 29, 2020 09:24
@noorulain17 noorulain17 changed the title Added Xcode 11.x compatibility by adding AppIcon & LaunchImages Added Xcode 11.x compatibility by adding AppIcon & LaunchScreen.storyboard Apr 29, 2020
@noorulain17 noorulain17 changed the title Added Xcode 11.x compatibility by adding AppIcon & LaunchScreen.storyboard Added Xcode 11.x compatibility & DarkMode support Apr 29, 2020
@skywinder
Copy link
Owner

💎Brilliant!💎
Thank you!

@skywinder
Copy link
Owner

@noorulain17 thanks for fixes of #473. It would be better to split it into 2 PR's. but let it go. Much apreciated for the help with project!

@skywinder skywinder merged commit 2bc61ab into skywinder:develop Apr 30, 2020
@noorulain17 noorulain17 deleted the added_Xcode_11.x_compatibility branch April 30, 2020 10:09
@mikemike396
Copy link

mikemike396 commented May 8, 2020

@noorulain17 Legend! 🍺

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants