Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japanese: Apply #479 changes to the documents #480

Closed
seratch opened this issue Sep 27, 2021 · 0 comments · Fixed by #494
Closed

Japanese: Apply #479 changes to the documents #480

seratch opened this issue Sep 27, 2021 · 0 comments · Fixed by #494
Assignees
Labels
docs Improvements or additions to documentation good first issue
Milestone

Comments

@seratch
Copy link
Member

seratch commented Sep 27, 2021

Refer to #479 for details

The page URLs

Requirements

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

@seratch seratch added docs Improvements or additions to documentation good first issue labels Sep 27, 2021
@seratch seratch added this to the 1.x milestone Sep 27, 2021
seratch added a commit that referenced this issue Oct 13, 2021
* fix #480 #479 for Japanese docs
* add in changes from Kazs comments
* Update docs/_basic/ja_listening_modals.md

Co-authored-by: Kazuhiro Sera <[email protected]>
@seratch seratch modified the milestones: 1.x, 1.11.0 Dec 14, 2021
@seratch seratch self-assigned this Dec 14, 2021
@seratch seratch modified the milestones: 1.11.0, 1.9.3 Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation good first issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant