Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds update view on submission docs #479

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Sep 27, 2021

Updates listening to views documentation to add example for updating via ack() response_action. After corresponding bolt-js changes

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@codecov
Copy link

codecov bot commented Sep 27, 2021

Codecov Report

Merging #479 (a7cbb09) into main (4e0709f) will not change coverage.
The diff coverage is n/a.

❗ Current head a7cbb09 differs from pull request most recent head 1e5ca04. Consider uploading reports for the commit 1e5ca04 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #479   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files         167      167           
  Lines        5523     5523           
=======================================
  Hits         5049     5049           
  Misses        474      474           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e0709f...1e5ca04. Read the comment docs.

@seratch seratch added the docs Improvements or additions to documentation label Sep 27, 2021
@seratch seratch added this to the 1.9.2 milestone Sep 27, 2021
@seratch seratch merged commit 7daf5c8 into slackapi:main Sep 27, 2021
@srajiang srajiang deleted the update_views_docs branch September 27, 2021 21:20
wongjas added a commit to wongjas/bolt-python that referenced this pull request Oct 13, 2021
seratch added a commit that referenced this pull request Oct 13, 2021
* fix #480 #479 for Japanese docs
* add in changes from Kazs comments
* Update docs/_basic/ja_listening_modals.md

Co-authored-by: Kazuhiro Sera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants