Add timestamps for enter and leave messages #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enter and leave messages don't have timestamps, unlike other events like text messages. Hubot doesn't have a place for them e.g. for enter messages in the EnterMessage class, but Slack supports them and other actions regarding enter/leave events in Slack expect you to use a timestamp, so you need to be able to get it from somewhere. This change works around the fact that they're not present in Hubot's classes by inserting a `ts` field after the message object has been created. It includes tests to confirm that Slack's event timestamp is successfully passed on to Hubot. Resolves #575
Codecov Report
@@ Coverage Diff @@
## master #596 +/- ##
==========================================
+ Coverage 85.10% 85.25% +0.14%
==========================================
Files 6 6
Lines 396 400 +4
Branches 88 88
==========================================
+ Hits 337 341 +4
Misses 34 34
Partials 25 25
Continue to review full report at Codecov.
|
seratch
approved these changes
May 15, 2020
|
Thanks! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enter and leave messages don't have timestamps, unlike other events like text messages. Hubot doesn't have a place for them e.g. for enter messages in the EnterMessage class, but Slack supports them and other actions regarding enter/leave events in Slack expect you to use a timestamp, so you need to be able to get it from somewhere.
This change works around the fact that they're not present in Hubot's classes by inserting a
tsfield after the message object has been created. It includes tests to confirm that Slack's event timestamp is successfully passed on to Hubot.Resolves #575
Requirements