Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamps for enter and leave messages #596

Merged
merged 1 commit into from
May 18, 2020
Merged

Add timestamps for enter and leave messages #596

merged 1 commit into from
May 18, 2020

Commits on May 5, 2020

  1. Add timestamps for enter and leave messages

    Enter and leave messages don't have timestamps, unlike other events like
    text messages.  Hubot doesn't have a place for them e.g. for enter
    messages in the EnterMessage class, but Slack supports them and other
    actions regarding enter/leave events in Slack expect you to use a
    timestamp, so you need to be able to get it from somewhere.
    
    This change works around the fact that they're not present in Hubot's
    classes by inserting a `ts` field after the message object has been
    created.  It includes tests to confirm that Slack's event timestamp is
    successfully passed on to Hubot.
    
    Resolves #575
    sionleroux committed May 5, 2020
    Configuration menu
    Copy the full SHA
    115a9a0 View commit details
    Browse the repository at this point in the history