Splat builder that works with ActionView::OutputBuffer #941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sketch of "have it work with Rails 7.1" for my app, it reacts to the fact that OutputBuffer no longer derives from String.
|
Could you please add a test cases which fails without this change and succeeds with it? |
|
I hope to! |
|
Fixed by #942 |
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sketch of "have it work with Rails 7.1" for my app, it reacts to the fact that OutputBuffer no longer derives from String.
I wanted to share this as soon as I had something that could possibly work, so I added no other long thoughts or good tests to this. I'd like feedback, thoughts, whether this can be checked at a much earlier stage, etc.