Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix splat arguments on Rails 7.1 #942

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

francescobbo
Copy link
Contributor

OutputBuffer has been changed to not inherit from String (and using the output safety core_ext from activesupport). With that change, the + has been removed.

This change replaces the += operator with concat, which is available on Strings and OutputBuffers alike.

I've added a test that fails without my patch on Rails 7.1.

@minad minad merged commit e71ec75 into slim-template:main Oct 7, 2023
7 checks passed
@bobmaerten
Copy link

Could we expect a release soon, now this is fixed?

@minad
Copy link
Member

minad commented Oct 19, 2023

@bobmaerten I will wait a little longer if more Rails 7.1 related issues pop up, see for example #943.

@gstokkink
Copy link

@minad I second the request for a release, this would help us a lot. That other bug you're referring to will be fixed in Rails 7.1.2, which is still a ways off.

@ryoung
Copy link

ryoung commented Nov 7, 2023

Any chance of a release? This fix has been merged a month ago.

@mgrunberg
Copy link

@minad would you consider a release now that Rails 7.1.2 got released? At least a rc.

@minad
Copy link
Member

minad commented Nov 11, 2023

Thanks. I noted the interest in an early release. But note that Rails 7.1.1 will still lead to breakage (#943). (EDIT: I see that Rails 7.1.2 has been released yesterday, so we should definitely proceed with this soon.) If Slim is useful for you, please consider supporting the maintenance of the project.

@slim-template slim-template locked as off-topic and limited conversation to collaborators Nov 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants