Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix splat arguments on Rails 7.1 #942

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fix splat arguments on Rails 7.1 #942

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/slim/splat/builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def attr(name, value)
end
if @attrs[name]
if delim = @options[:merge_attrs][name]
@attrs[name] += delim + value.to_s
@attrs[name].concat(delim + value.to_s)
else
raise("Multiple #{name} attributes specified")
end
Expand Down
1 change: 1 addition & 0 deletions test/rails/app/views/slim/splat_with_delimiter.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
.cute *{class: "nice"} Hello
5 changes: 5 additions & 0 deletions test/rails/test/test_slim.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,4 +94,9 @@ class TestSlim < ActionDispatch::IntegrationTest
get "/slim/splat"
assert_html "<div id=\"splat\"><splat>Hello</splat></div>"
end

test "splat with delimiter" do
get "/slim/splat_with_delimiter"
assert_html "<div class=\"cute nice\">Hello</div>"
end
end