Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CRD generation #59

Closed
3 of 11 tasks
snowdrop-bot opened this issue Apr 15, 2021 · 0 comments
Closed
3 of 11 tasks

Fix CRD generation #59

snowdrop-bot opened this issue Apr 15, 2021 · 0 comments
Assignees
@metacosm
Labels
7 - Community development upstream/closed The issue has been closed in the upstream repository

Comments

@snowdrop-bot
Copy link

Description

In the process of fixing tests after they moved out, we realized tha

  1. these tests were not running
  2. the CRD generation was not properly working:
    • status sub-resource was not properly generated from APT
    • schema generation was broken from API

Fixes fabric8io#2910
Supersedes fabric8io#2969

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

fabric8io#2996

$upstream:2996$
@snowdrop-bot snowdrop-bot added the upstream/closed The issue has been closed in the upstream repository label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@metacosm metacosm

Labels
7 - Community development upstream/closed The issue has been closed in the upstream repository
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@metacosm @snowdrop-bot