Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move crd-generator tests out of kubernetes-itests #2910

Closed
jorsol opened this issue Mar 15, 2021 · 3 comments · Fixed by #2996
Closed

Move crd-generator tests out of kubernetes-itests #2910

jorsol opened this issue Mar 15, 2021 · 3 comments · Fixed by #2996
Assignees

Comments

@jorsol
Copy link
Contributor

jorsol commented Mar 15, 2021

The tests/folder in https://github.com/fabric8io/kubernetes-client/tree/master/kubernetes-itests/src/test/java/io/fabric8/crd is not an "integration test", it doesn't need a connection to an active kubernetes cluster, so it should not belong to the kubernetes-itests module.

As this is more a "unit test" like, probably it should be inside the same crd-generator-apt module, or at best in the module kubernetes-test module.

Just as a side note, this test is not running on CI, since the e2e-tests workflow filter the tests that are from -Dtest="io.fabric8.[kubernetes|openshift].**" not the io.fabric8.crd.

/cc @metacosm

@metacosm
Copy link
Collaborator

We need to improve the coverage for the CRD generator as well.

@metacosm
Copy link
Collaborator

As this is more a "unit test" like, probably it should be inside the same crd-generator-apt module, or at best in the module kubernetes-test module.

Problem is you need the artifact to exist and the annotation processor in it to run on the test sources so it's not really feasible to put the tests in the same module.

@jorsol
Copy link
Contributor Author

jorsol commented Mar 15, 2021

As this is more a "unit test" like, probably it should be inside the same crd-generator-apt module, or at best in the module kubernetes-test module.

Problem is you need the artifact to exist and the annotation processor in it to run on the test sources so it's not really feasible to put the tests in the same module.

Then maybe into kubernetes-tests?

@rohanKanojia rohanKanojia self-assigned this Apr 6, 2021
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Apr 6, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Apr 6, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Apr 6, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Apr 6, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Apr 7, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Apr 8, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Apr 9, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
metacosm pushed a commit to iocanel/kubernetes-client that referenced this issue Apr 15, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
@metacosm metacosm mentioned this issue Apr 15, 2021
11 tasks
manusa pushed a commit to manusa/kubernetes-client that referenced this issue Apr 22, 2021
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests

(cherry picked from commit 80a0fed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants