-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move crd-generator tests out of kubernetes-itests #2910
Comments
We need to improve the coverage for the CRD generator as well. |
Problem is you need the artifact to exist and the annotation processor in it to run on the test sources so it's not really feasible to put the tests in the same module. |
Then maybe into |
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests (cherry picked from commit 80a0fed)
The tests/folder in https://github.com/fabric8io/kubernetes-client/tree/master/kubernetes-itests/src/test/java/io/fabric8/crd is not an "integration test", it doesn't need a connection to an active kubernetes cluster, so it should not belong to the
kubernetes-itests
module.As this is more a "unit test" like, probably it should be inside the same
crd-generator-apt
module, or at best in the modulekubernetes-test
module.Just as a side note, this test is not running on CI, since the e2e-tests workflow filter the tests that are from
-Dtest="io.fabric8.[kubernetes|openshift].**"
not the io.fabric8.crd./cc @metacosm
The text was updated successfully, but these errors were encountered: