-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CRD generation #2996
Merged
Merged
Fix CRD generation #2996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ Move crd-generator tests from kubernetes-itests -> kubernetes-tests
Also added commented out tests to check instantiability of the returned class name, which currently doesn't work because we get the equivalent of the canonical name which isn't suitable for class loading. We should be able to consume the returned class name as-is, imo.
Can one of the admins verify this patch? |
11 tasks
Note that this requires a new sundrio release. |
11 tasks
This was referenced Apr 15, 2021
Closed
11 tasks
manusa
reviewed
Apr 16, 2021
crd-generator/api/src/main/java/io/fabric8/crd/generator/CustomResourceInfo.java
Show resolved
Hide resolved
fix: avoid projecting properties twice
This is controlled by a compilation-time flag.
metacosm
force-pushed
the
crd-generator-playground
branch
from
April 16, 2021 15:52
ce1a8f0
to
e8a948d
Compare
SonarCloud Quality Gate failed. |
manusa
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
rohanKanojia
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the process of fixing tests after they moved out, we realized tha
Fixes #2910
Supersedes #2969
Type of change
test, version modification, documentation, etc.)
Checklist