Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-859796 Get rid of SFL4J logging messages #1465

Merged
merged 5 commits into from
Jul 13, 2023
Merged

SNOW-859796 Get rid of SFL4J logging messages #1465

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
983dfce
Revert "Revert "SNOW-848855: Change SLF4J scope to compile" (#1463)"
sfc-gh-mknister Jul 6, 2023
fd64ac3
added no-op to pom
sfc-gh-mknister Jul 7, 2023
5a69e75
taking away no-op
sfc-gh-mknister Jul 11, 2023
346c02c
added relocation
sfc-gh-mknister Jul 12, 2023
58a4cc4
Merge branch 'master' into fixErrorMessage
sfc-gh-mknister Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,12 @@
<artifactId>asm</artifactId>
<version>9.3</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>2.0.6</version>
sfc-gh-mknister marked this conversation as resolved.
Show resolved Hide resolved
<scope>compile</scope>
</dependency>
<dependency>
<groupId>org.threeten</groupId>
<artifactId>threetenbp</artifactId>
Expand All @@ -213,12 +219,6 @@
<artifactId>xz</artifactId>
<version>1.9</version>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
<version>2.0.6</version>
<scope>provided</scope>
</dependency>
</dependencies>
</dependencyManagement>

Expand Down Expand Up @@ -1151,6 +1151,10 @@
<pattern>org.codehaus</pattern>
<shadedPattern>${shadeBase}.org.codehaus</shadedPattern>
</relocation>
<relocation>
<pattern>org.slf4j</pattern>
<shadedPattern>${shadeBase}.org.slf4j</shadedPattern>
</relocation>
<relocation>
<pattern>io.perfmark</pattern>
<shadedPattern>${shadeBase}.io.perfmark</shadedPattern>
Expand Down