Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-859796 Get rid of SFL4J logging messages #1465

Merged
merged 5 commits into from
Jul 13, 2023
Merged

SNOW-859796 Get rid of SFL4J logging messages #1465

merged 5 commits into from
Jul 13, 2023

Conversation

sfc-gh-mknister
Copy link
Contributor

@sfc-gh-mknister sfc-gh-mknister commented Jul 7, 2023 •
edited
Loading

Overview

SNOW-859796

This must be merged after https://github.com/snowflakedb/snowflake/pull/112537 so as to avoid BPTP failures.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-mknister sfc-gh-mknister requested a review from a team as a code owner July 7, 2023 18:56
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the quick turn around.

sfc-gh-pfus
sfc-gh-pfus reviewed Jul 10, 2023
View reviewed changes
ci/scripts/check_content.sh Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
sfc-gh-dprzybysz
sfc-gh-dprzybysz reviewed Jul 10, 2023
View reviewed changes
pom.xml Outdated Show resolved Hide resolved
pom.xml Show resolved Hide resolved
@sfc-gh-mknister sfc-gh-mknister changed the title Get rid of SFL4J logging messages SNOW-859796 Get rid of SFL4J logging messages Jul 10, 2023
@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-mknister sfc-gh-mknister merged commit 977e459 into master Jul 13, 2023
12 checks passed
@sfc-gh-mknister sfc-gh-mknister deleted the fixErrorMessage branch July 13, 2023 20:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb left review comments

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-mknister @sfc-gh-igarish @sfc-gh-ext-simba-lb @sfc-gh-dprzybysz @sfc-gh-pfus