Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "SNOW-811265 Do not close channel on rebalance (#651)" #678

Merged
merged 1 commit into from
Jul 28, 2023

Revert "SNOW-811265 Do not close channel on rebalance (#651)"

90bc562
Select commit
Loading
Failed to load commit list.
Merged

Revert "SNOW-811265 Do not close channel on rebalance (#651)" #678

Revert "SNOW-811265 Do not close channel on rebalance (#651)"
90bc562
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 28, 2023 in 0s

87.93% (-0.05%) compared to 0f570ee

View this Pull Request on Codecov

87.93% (-0.05%) compared to 0f570ee

Details

Codecov Report

Merging #678 (90bc562) into master (0f570ee) will decrease coverage by 0.05%.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master     #678      +/-   ##
==========================================
- Coverage   87.97%   87.93%   -0.05%     
==========================================
  Files          50       50              
  Lines        4143     4143              
  Branches      451      452       +1     
==========================================
- Hits         3645     3643       -2     
- Misses        330      331       +1     
- Partials      168      169       +1     
Files Changed Coverage Δ
...tor/internal/streaming/SnowflakeSinkServiceV2.java 80.12% <50.00%> (-0.74%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more