Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

igluctl: fix incorrect generation of Redshift and JSON Path filenames #271

Closed
chuwy opened this issue Oct 17, 2017 · 7 comments
Closed

igluctl: fix incorrect generation of Redshift and JSON Path filenames #271

chuwy opened this issue Oct 17, 2017 · 7 comments
Assignees
@chuwy @oguzhanunlu
Labels
bug
Milestone
Release 7 Treskil...

Comments

@chuwy
Copy link
Contributor

chuwy commented Oct 17, 2017

For input com.acme/event-with-dashes/jsonschema/1-0-0, static generate outputs event-with-dashes_1.sql and event-with-dashes_1.json files, which should have underscores instead of dashes to be consistent with StorageLoader and RDB Loader.
@chuwy chuwy added this to the Release 7 Stamp TBC milestone Oct 17, 2017
@chuwy chuwy changed the title Igluctl: make Redshift table name and JSONPaths consistent with loader Igluctl: make Redshift table name and JSONPaths consistent with loaders Oct 17, 2017
@alexanderdean
Copy link
Member

Use the bug label when we find a bug!

@alexanderdean alexanderdean changed the title Igluctl: make Redshift table name and JSONPaths consistent with loaders igluctl: make Redshift table name and JSONPaths consistent with loaders Nov 1, 2017
@chuwy chuwy mentioned this issue Nov 16, 2017
Closed
@oguzhanunlu oguzhanunlu mentioned this issue Nov 17, 2017
Closed
32 tasks
oguzhanunlu added a commit that referenced this issue Nov 20, 2017
@oguzhanunlu
igluctl: make Redshift table name and JSONPaths consistent with loade…
a65c1fc 
…rs (close #271)
@oguzhanunlu oguzhanunlu mentioned this issue Nov 20, 2017
Closed
@oguzhanunlu
Copy link
Member

Since this issue's fix also handles #265 & #226, I closed them manually and let this one stay since its name is the best among three to stay in commit log.

oguzhanunlu added a commit that referenced this issue Dec 11, 2017
@oguzhanunlu
igluctl: make Redshift table name and JSONPaths consistent with loade…
e5b9821 
…rs (close #271)
@alexanderdean
Copy link
Member

Can we come up with a better name for this ticket? It's a bit messy/confusing

@oguzhanunlu
Copy link
Member

@alexanderdean What about igluctl: fix incorrect generation of Redshift table names and JSONPath filenames ?

@alexanderdean
Copy link
Member

Is it the Redshift table name? Or the filename?

@oguzhanunlu
Copy link
Member

oguzhanunlu commented Dec 14, 2017 •
edited
Loading

@alexanderdean I checked again and it is a problem with filename, not table name.

What about igluctl: fix incorrect generation of Redshift and JSONPath filenames ?

@alexanderdean alexanderdean changed the title igluctl: make Redshift table name and JSONPaths consistent with loaders igluctl: fix incorrect generation of Redshift and JSON Path filenames Dec 14, 2017
@alexanderdean
Copy link
Member

Good, added a space in JSON Path

oguzhanunlu added a commit that referenced this issue Dec 14, 2017
@oguzhanunlu
igluctl: fix incorrect generation of Redshift and JSON Path filenames (…
9010dd1 
…close #271)
chuwy pushed a commit that referenced this issue Dec 15, 2017
@oguzhanunlu @chuwy
igluctl: fix incorrect generation of Redshift and JSON Path filenames (…
4c567a1 
…close #271)
chuwy pushed a commit that referenced this issue Dec 18, 2017
@oguzhanunlu @chuwy
igluctl: fix incorrect generation of Redshift and JSON Path filenames (…
59213ef 
…close #271)
oguzhanunlu added a commit that referenced this issue Dec 18, 2017
@oguzhanunlu
igluctl: fix incorrect generation of Redshift and JSON Path filenames (…
2964765 
…close #271)
oguzhanunlu added a commit that referenced this issue Dec 18, 2017
@oguzhanunlu
igluctl: fix incorrect generation of Redshift and JSON Path filenames (…
bab4aea 
…close #271)
oguzhanunlu added a commit that referenced this issue Dec 18, 2017
@oguzhanunlu
igluctl: fix incorrect generation of Redshift and JSON Path filenames (…
082f119 
…close #271)
oguzhanunlu added a commit that referenced this issue Feb 20, 2018
@oguzhanunlu
igluctl: fix incorrect generation of Redshift and JSON Path filenames (…
e763d65 
…close #271)
rzats pushed a commit to snowplow/igluctl that referenced this issue Mar 22, 2019
@oguzhanunlu @rzats
Fix incorrect generation of Redshift and JSON Path filenames (close s…
68f1033 
…nowplow/iglu#271)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chuwy chuwy

@oguzhanunlu oguzhanunlu

Labels
bug
Projects
None yet
Milestone
Release 7 Treskilling Yellow
Development

No branches or pull requests
3 participants
@alexanderdean @chuwy @oguzhanunlu