Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/r7 #280

Closed
wants to merge 0 commits into from
Closed

Release/r7 #280

wants to merge 0 commits into from

Conversation

oguzhanunlu
Copy link
Member

@oguzhanunlu oguzhanunlu commented Nov 10, 2017

@oguzhanunlu oguzhanunlu added this to the Release 7 Stamp TBC milestone Nov 10, 2017
@oguzhanunlu oguzhanunlu self-assigned this Nov 10, 2017
@chuwy
Copy link
Contributor

chuwy commented Nov 11, 2017

Hey @oguzhanunlu, unfortunately we already released Penny Black as R3. If you're still looking for something Turkey-related, you can check out this list: https://en.wikipedia.org/wiki/Postage_stamps_and_postal_history_of_Turkey

@oguzhanunlu
Copy link
Member Author

Oh, I didn't notice that. Thanks @chuwy ! Then let it be Adrianople.

@@ -22,7 +22,7 @@ object BuildSettings {
organization := "com.snowplowanalytics",
version := "0.2.0",
description := "Scala schema server for Iglu",
scalaVersion := "2.10.1",
scalaVersion := "2.10.4",
Copy link
Member Author

@oguzhanunlu oguzhanunlu Nov 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current Scala version, 2.10.1, isn't compatible with JDK8 compiled classes, e.g. https://travis-ci.org/snowplow/iglu/builds/300073622#L1004 , thus I inserted a temporary bump in Scala 2.10.x which fixes issues with Java 8. Kafka had a similar issue here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right. But please, bump it to latest 2.10.6.

@chuwy
Copy link
Contributor

chuwy commented Nov 16, 2017

Hey @oguzhanunlu, could you give me some insights on how to read above check-list? Do you add unchecked items when you pushed a relevant commit into branch?

Those are of course for you, but it would be useful for me if I'll be able to interpret them correctly.

@chuwy
Copy link
Contributor

chuwy commented Nov 16, 2017

Hey @oguzhanunlu, have a look at this one and please, do following:

  1. Implement it and put somewhere in the root of your branch
  2. create and implement similar ones for Igluctl (0.3.0) and Schema DDL (0.7.0?)
  3. create bumps for inner dependencies, like igluctl: bump Schema DDL to 0.7.0 and push these bumps
  4. when you're done with above, please do publishLocal for libraries and +test (note +) - it'll test apps across all versions.

Above makes our R7 release to contain not just 3rd-party, but also our own fresh libs. Right now we're just doing separate releases, which is almost useless.

Unrelated: please rename all tickets like Schema DDL: Add Scala 2.12 support to Schema DDL: add Scala 2.12 support (lowercase in second part). Sorry for bike-shedding, but we want our changelog to be consistent.

@oguzhanunlu
Copy link
Member Author

oguzhanunlu commented Nov 16, 2017

@chuwy For first question, yes, I follow that. I was working on #265 today and will look at #292. Will update commit messages as well.

@chuwy
Copy link
Contributor

chuwy commented Nov 21, 2017

Hey @oguzhanunlu, I see you're doing good progress on Iglu-refreshment. Let me know what do you think about adding #147 and #167 to scope of this release. I have several reasons to propose that:

  1. This will unblock some work related to Schema inference meta-ticket #263 in other libraries and these particular issues (Scala Core: add support for Unversioned Schema #147 and Scala Core: split SchemaKey into data- and schema-specific #167) do not look experimental or hard to implement. At the same time now I'm quite confident this is the right way to go
  2. It doesn't feel right to release next non-patch version of core library with such minor changes as we currently have
  3. If we'll implement this - we'll be able to start using Iglu Core more actively as it'll include quite solid ground for versioning

Please let me know of what impact it will have for R7 ETA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants