[CTX-601] chore: fix various AWS acceptance tests #1662
Conversation
In order to trigger acceptance tests for certain branches pre-merge, and without having to wait for a nightly build, you can click "trigger pipeline" in CircleCI and enter `ACC_TESTS=1` as a parameter.
craigfurman
force-pushed
the
acctest-fixes
branch
from
00b01d2
to
01b24be
Compare
|
Triggered manual acceptance tests using the CI capability introduced in the 3rd commit here to see if this is an improvement 🤞 https://app.circleci.com/pipelines/github/snyk/driftctl/5228/workflows/0f811d60-10a5-431e-a7fd-8887d21d4bd0 |
| function_name = "event-source-mapping-test-lambda-${local.timestamp}" | ||
| role = aws_iam_role.iam_for_lambda.arn | ||
| handler = "exports.test" | ||
| runtime = "nodejs14.x" |
There was a problem hiding this comment.
what's the reason this one is node 14 and line 89 at pkg/resource/aws/testdata/acc/aws_apigatewayv2_authorizer/terraform.tf is node 18? can't spot the difference and the original one are both the same version
There was a problem hiding this comment.
See description 🙂
|
@karniwl good call, I've pushed a commit to change those GCP fixtures just now. I haven't run those tests yet, but GCP acc tests are already broken - and are next on the list to fix! This should alleviate concerns around those IAM fixtures in the mean time. |
One test fixture had a duplicate provider block, rendering it invalid. Others contained references to users that are actually groups, a recent regression in #1662.
chore: fix various AWS acceptance tests
chore: re-enable nightly acceptance tests
This reverts commit 9907b1c.
chore: manual acceptance test job
In order to trigger acceptance tests for certain branches pre-merge, and
without having to wait for a nightly build, you can click "trigger
pipeline" in CircleCI and enter
ACC_TESTS=1as a parameter.chore: remove references to non-Snyk domains in acc test fixtures
Attempt to fix failing AWS acceptance tests from https://app.circleci.com/pipelines/github/snyk/driftctl/5206/workflows/2425c0ab-f8a5-4594-8605-0e532e55ca88/jobs/13441/tests. Unless otherwise stated, I got a passing test against my sandbox account.
aws_s3_bucket#471, and it's unclear from that PR why that was important to do. I removed all but one bucket from the test fixture, and removed all policy attachments to get this applying successfully at all. I would hope the relevant bucket policy attachment middlewares catch regressions here, but there's a chance this PR just encodes an already-occurred regression.There are lots of formatting artifacts from my editor automatically terraform-fmting files, sorry!