[CTX-601] chore: fix some Google acceptance tests #1665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test fixture had a duplicate provider block, rendering it invalid. Others contained references to users that are actually groups, a recent regression in #1662.
agatakrajewska
approved these changes
Jun 1, 2023
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test fixture had a duplicate provider block, rendering it invalid. Others contained references to users that are actually groups, a recent regression in #1662.
I haven't actually been able to run any of these, I can't quite figure out how from my laptop... I've tried ADC, and overrides using a service account key with
GOOGLE_APPLICATION_CREDENTIALS=/path/to/key.json CLOUDSDK_CORE_PROJECT=my-sandbox .... I'll run acceptance tests in circleCI on this branch.