Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix power flow initialisation of synchronous generators #238

Merged
merged 10 commits into from
Nov 30, 2023
Merged

Fix power flow initialisation of synchronous generators #238

merged 10 commits into from
Nov 30, 2023

Conversation

martinmoraga
Copy link
Contributor

@martinmoraga martinmoraga commented Jul 27, 2023 •
edited by dinkelbachjan
Loading

In powerflow simulations, the power of synchronous generators is not being always correctly calculated, since the power of the loads connected to nodes is not considered in the calculation. This PR fixes the calculation of the synchronous generators' power in powerflow simulations and adapts the funcion initWithPowerFlow to initialialize the terminal power of the synchronous generators after the powerflow calculation.

Closes #223

@martinmoraga martinmoraga added the bug Something isn't working label Jul 27, 2023
@martinmoraga martinmoraga self-assigned this Jul 27, 2023
@martinmoraga martinmoraga linked an issue Jul 27, 2023 that may be closed by this pull request
Fix power flow initialisation & updating for the terminals #223
Closed
@martinmoraga martinmoraga mentioned this pull request Jul 27, 2023
Closed
@martinmoraga martinmoraga force-pushed the fix_power_flow_initialisation branch 2 times, most recently from 9f939e8 to ad63eed Compare August 3, 2023 09:18
@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@martinmoraga martinmoraga force-pushed the fix_power_flow_initialisation branch 2 times, most recently from fbd388e to 304b1dc Compare October 19, 2023 09:09
@dinkelbachjan dinkelbachjan mentioned this pull request Oct 19, 2023
Open
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@dinkelbachjan dinkelbachjan mentioned this pull request Nov 30, 2023
Open
@dinkelbachjan dinkelbachjan changed the title Fix power flow initialisation & updating for the terminals Fix power flow initialisation of synchronous generators Nov 30, 2023
@dinkelbachjan dinkelbachjan merged commit 4b9ab5f into master Nov 30, 2023
22 checks passed
@dinkelbachjan dinkelbachjan mentioned this pull request Dec 4, 2023
Open
@stv0g stv0g deleted the fix_power_flow_initialisation branch February 28, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinkelbachjan dinkelbachjan dinkelbachjan approved these changes

Assignees

@martinmoraga martinmoraga

@dinkelbachjan dinkelbachjan

@gnakti gnakti

Labels
bug Something isn't working
Projects
DPsim
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix power flow initialisation & updating for the terminals
3 participants
@martinmoraga @dinkelbachjan @gnakti