Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge offline validators #344

Closed
garious opened this issue Jun 13, 2018 · 4 comments
Closed

Purge offline validators #344

garious opened this issue Jun 13, 2018 · 4 comments
Milestone

Comments

@garious
Copy link
Contributor

garious commented Jun 13, 2018

Avalanche will split segments between all validators. If very few are offline, erasure codes can be used to fill the gaps, but if too many, the validators will need to request the missing segments, which is very slow. Nodes should actively identify offline nodes and purge them.

@garious garious added this to the v0.7.0 milestone Jun 13, 2018
@garious
Copy link
Contributor Author

garious commented Jun 13, 2018

@aeyakovenko, can you recommend an entrypoint for this code?

@aeyakovenko
Copy link
Member

we should see a RequestUpdate from nodes in the network.
https://github.com/solana-labs/solana/blob/master/src/crdt.rs#L565
and we can mark them as stale if we don't see them often enough

@carllin
Copy link
Contributor

carllin commented Jun 13, 2018

@aeyakovenko, right now the validators pick random peers to RequestUpdate from, so should we just set the timeout to be sufficiently long so that the probability that two peers will connect is very high? Or we could set a timeout period after which a validator can send an explicit heartbeat request if they suspect a node on the network might be offline.

@aeyakovenko
Copy link
Member

@carllin initially we can set the timeout long enough, and eventually we can start gossip availability stats between nodes and aggregate those values. The latter is tricky because we can’t trust rumors from adversarial nodes on the network

aeyakovenko added a commit that referenced this issue Jun 13, 2018
* Needed for #341. Create a dummy entry with public key 0..., but with a valid gossip address that we can ask for updates. This will allow validators to discover the full network by just knowing a single node's gossip address without knowing anything else about their identity.
* once we start removing dead validators this entry should get purged since we will never see a message from public key 0, #344
brooksprumo pushed a commit to brooksprumo/solana that referenced this issue Apr 2, 2024
…olana-labs#344)

Enable accountsdb_scan_account_storage_no_bank tests for hot storage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants