allow for insertion of dummy entry points into the local table #346
Conversation
Codecov Report
@@ Coverage Diff @@
## master #346 +/- ##
==========================================
+ Coverage 91.11% 91.34% +0.23%
==========================================
Files 34 34
Lines 3365 3375 +10
==========================================
+ Hits 3066 3083 +17
+ Misses 299 292 -7
Continue to review full report at Codecov.
|
| @@ -134,6 +133,17 @@ impl ReplicatedData { | |||
| repair_addr, | |||
| ) | |||
| } | |||
| pub fn new_entry_point(gossip_addr: SocketAddr) -> Self { | |||
There was a problem hiding this comment.
What do you mean by entry_point here? Would new_from_base_addr make more sense?
There was a problem hiding this comment.
By entry point I meant that it’s a gossip network entry point, it’s a dummy entry that had an invalid public key. It’s used to attach to the network initially and will eventually get purged
There was a problem hiding this comment.
Can you add code comments? You don't add a test in this PR and the only explanation is in the PR description and the review comment above.
There was a problem hiding this comment.
Nevermind, I just didn't grok the test.
0..., but with a valid gossip address that we can ask for updates. This will allow validators to discover the full network by just knowing a single node's gossip address without knowing anything else about their identity.