Remove immutable deploy #28399
Merged
Remove immutable deploy #28399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2022
KirillLykov
force-pushed
the
remove_immutable_deploy
branch
2 times, most recently
from
1c98d3a
to
17629eb
Compare
jstarry
previously approved these changes
Oct 19, 2022
| @@ -679,26 +672,6 @@ pub fn parse_command( | |||
| } | |||
| ("upgrade-nonce-account", Some(matches)) => parse_upgrade_nonce_account(matches), | |||
| // Program Deployment | |||
| ("deploy", Some(matches)) => { | |||
There was a problem hiding this comment.
What do you think about leaving the SubCommand and using this match case to return an Error exit pointing users at solana program deploy?
There was a problem hiding this comment.
Might be good for user experience. I've added back deploy in 2a5b910
CriesofCarrots
previously approved these changes
Oct 20, 2022
KirillLykov
force-pushed
the
remove_immutable_deploy
branch
from
2a5b910
to
e51470b
Compare
mergify
bot
dismissed
CriesofCarrots’s stale review
Pull request has been modified.
gnapoli23
pushed a commit
to gnapoli23/solana
that referenced
this pull request
Dec 16, 2022
* remove Deploy option from cli * remove solana deploy from comments * introduce dummy deploy command to improve user experience
nickfrosty
pushed a commit
to nickfrosty/solana
that referenced
this pull request
Jan 4, 2023
* remove Deploy option from cli * remove solana deploy from comments * introduce dummy deploy command to improve user experience
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR is to remove
solana deploycommand, see #27834This PR depends on:
#28398 (merged)
#28448 (merged)
Summary of Changes
deploysubcommandsolana deploycommand from code documentation