Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change test validator from non upgradable bpf loader to upgradable bpf loader #29051

Merged
merged 1 commit into from
Dec 5, 2022

Conversation

lucarlig
Copy link
Contributor

@lucarlig lucarlig commented Dec 2, 2022

Problem

while trying to run anchor test the program_data account of the program that is automatically deployed does not initialize, so some tests won't run.
If you just run anchor test against a local network, it will start a new test validator using the --bpf-program argument with solana-test-validator, which defaults to the non-upgradeable loader

Summary of Changes

just change from using bpf_loader to bpf_loader_upgradeable

reference from StackOverflow question: https://solana.stackexchange.com/questions/4632/anchorerror-caused-by-account-program-data-error-code-accountnotinitialized/4691#4691

@mergify mergify bot added the community Community contribution label Dec 2, 2022
@mergify mergify bot requested a review from a team December 2, 2022 20:10
@mvines mvines added the CI Pull Request is ready to enter CI label Dec 3, 2022
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Dec 3, 2022
@mvines mvines requested a review from joncinque December 5, 2022 18:31
@mvines
Copy link
Member

mvines commented Dec 5, 2022

@joncinque - wdyt? I think this makes sense

@joncinque
Copy link
Contributor

@mvines considering solana deploy was deprecated with #28399, we can be sure that very few people mean to use the immutable loader, so it makes sense for the test validator to work that way too. Also, that person is referencing my answer, so I think it's a great idea 😁

@mvines
Copy link
Member

mvines commented Dec 5, 2022

Thanks @lucarlig and @joncinque

@mvines mvines merged commit b43eaba into solana-labs:master Dec 5, 2022
gnapoli23 pushed a commit to gnapoli23/solana that referenced this pull request Dec 16, 2022
…f loader (solana-labs#29051)

change for test validator from non upgradable to upgradable
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Jan 4, 2023
…f loader (solana-labs#29051)

change for test validator from non upgradable to upgradable
CriesofCarrots added a commit to CriesofCarrots/solana that referenced this pull request Feb 20, 2023
CriesofCarrots added a commit to CriesofCarrots/solana that referenced this pull request Feb 20, 2023
CriesofCarrots added a commit that referenced this pull request Feb 20, 2023
#30409)

Revert "change test validator from non upgradable bpf loader to upgradable bpf loader (#29051)"

This reverts commit b43eaba.
mergify bot pushed a commit that referenced this pull request Feb 20, 2023
#30409)

Revert "change test validator from non upgradable bpf loader to upgradable bpf loader (#29051)"

This reverts commit b43eaba.

(cherry picked from commit 47777c4)
nickfrosty pushed a commit to nickfrosty/solana that referenced this pull request Mar 12, 2023
solana-labs#30409)

Revert "change test validator from non upgradable bpf loader to upgradable bpf loader (solana-labs#29051)"

This reverts commit b43eaba.
vadorovsky pushed a commit to Lightprotocol/solana that referenced this pull request May 13, 2023
solana-labs#30409)

Revert "change test validator from non upgradable bpf loader to upgradable bpf loader (solana-labs#29051)"

This reverts commit b43eaba.

(cherry picked from commit 47777c4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants