Error handling cleanup #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error handling is still clumsy. We should switch to something like `error-chain` or `Result<T, Box<Error>>`, but until then, we can at least be consistent across modules.
By removing the exit variables, the downstream stages wait for upstream stages to drop their senders before exiting.
garious
force-pushed
the
cleanup
branch
2 times, most recently
from
951bfb8
to
743a96e
Compare
And drop the sender that feeds input to the responder.
aeyakovenko
reviewed
Jul 5, 2018
| match e { | ||
| Error::RecvTimeoutError(RecvTimeoutError::Disconnected) => break, | ||
| Error::RecvTimeoutError(RecvTimeoutError::Timeout) => (), | ||
| Error::CrdtError(CrdtError::TooSmall) => (), // TODO: Why are the unit-tests throwing hundreds of these? |
There was a problem hiding this comment.
the state transitions there are complicated. you would need to boot, wait for the network to grow to N, then if it drops below MIN throw the error.
aeyakovenko
approved these changes
Jul 5, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
) Bumps [flow-bin](https://github.com/flowtype/flow-bin) from 0.134.0 to 0.135.0. - [Release notes](https://github.com/flowtype/flow-bin/releases) - [Commits](https://github.com/flowtype/flow-bin/commits) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
yihau
added a commit
to yihau/solana
that referenced
this pull request
Apr 6, 2024
* remove InetAddr from streamer/src/sendmmsg.rs * add ref links * use SocketAddr conversion directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error handling is still clumsy. We should switch to something like
error-chainorResult<T, Box<Error>>, but until then, we canat least be consistent across modules.
This PR also removed exit variables from all stages that are not listening on a UdpSocket as their only input.
cc: #232