Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling cleanup #557

Merged
merged 13 commits into from
Jul 5, 2018
Merged

Error handling cleanup #557

merged 13 commits into from
Jul 5, 2018

Commits on Jul 5, 2018

  1. Fix code comments

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    d154e0f View commit details
    Browse the repository at this point in the history

  2. Remove executable bit from nat.rs

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    a5ae0f5 View commit details
    Browse the repository at this point in the history

  3. Handle errors consistently 

    Error handling is still clumsy. We should switch to something like
`error-chain` or `Result<T, Box<Error>>`, but until then, we can
at least be consistent across modules.
    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    cee34f7 View commit details
    Browse the repository at this point in the history

  4. Exit write_stage on channel errors

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    0a55fce View commit details
    Browse the repository at this point in the history

  5. Remove exit variable from WriteStage

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    036afc7 View commit details
    Browse the repository at this point in the history

  6. Remove exit variable from BankingStage

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    19e951f View commit details
    Browse the repository at this point in the history

  7. Remove exit variable from broadcast [stage]

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    f090f26 View commit details
    Browse the repository at this point in the history

  8. No longer need to ignore downstream send errors 

    By removing the exit variables, the downstream stages wait for
upstream stages to drop their senders before exiting.
    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    2c71b3a View commit details
    Browse the repository at this point in the history

  9. Remove exit variable from VerifyStage

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    09d6900 View commit details
    Browse the repository at this point in the history

  10. Remove exit variable from ReplicateStage

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    743a96e View commit details
    Browse the repository at this point in the history

  11. Remove exit variable from WindowStage and retransmit [stage]

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    38a7345 View commit details
    Browse the repository at this point in the history

  12. Remove exit variable from respond [stage] 

    And drop the sender that feeds input to the responder.
    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    bd620d5 View commit details
    Browse the repository at this point in the history

  13. Remove exit variable from RequestStage

    @garious
    garious committed Jul 5, 2018
    Configuration menu
    Copy the full SHA
    2df1259 View commit details
    Browse the repository at this point in the history