perf: use absl string append (envoyproxy#28959)

Signed-off-by: Boteng Yao <[email protected]>
solo-io · Aug 11, 2023 · c1abe8a · c1abe8a
1 parent f2e5620
commit c1abe8a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/source/common/router/header_parser_utils.cc b/source/common/router/header_parser_utils.cc
@@ -39,7 +39,7 @@ std::string HeaderParser::translateMetadataFormat(const std::string& header_valu
       }
       new_format = parsed_params->asObjectArray()[0]->asString();
       for (size_t i = 1; i < parsed_params->asObjectArray().size(); i++) {
-        new_format += ":" + parsed_params->asObjectArray()[i]->asString();
+        absl::StrAppend(&new_format, ":", parsed_params->asObjectArray()[i]->asString());
       }
 
       new_format = absl::StrCat("%", matches[1], "_METADATA(", new_format, ")%");

diff --git a/source/common/runtime/runtime_impl.cc b/source/common/runtime/runtime_impl.cc
@@ -720,7 +720,7 @@ SnapshotImplPtr LoaderImpl::createNewSnapshot() {
       std::string path =
           layer.disk_layer().symlink_root() + "/" + layer.disk_layer().subdirectory();
       if (layer.disk_layer().append_service_cluster()) {
-        path += "/" + service_cluster_;
+        absl::StrAppend(&path, "/", service_cluster_);
       }
       if (api_.fileSystem().directoryExists(path)) {
         TRY_ASSERT_MAIN_THREAD {

diff --git a/source/extensions/filters/udp/dns_filter/dns_filter_utils.cc b/source/extensions/filters/udp/dns_filter/dns_filter_utils.cc
@@ -52,11 +52,11 @@ std::string buildServiceName(const std::string& name, const std::string& proto,
   if (name[0] != '_') {
     result += "_";
   }
-  result += name + ".";
+  absl::StrAppend(&result, name, ".");
   if (proto[0] != '_') {
     result += "_";
   }
-  result += proto + '.' + domain;
+  absl::StrAppend(&result, proto, ".", domain);
   return result;
 }