[ADD] PHP-CS-Fixer

[Th3Mouk]

Proposition

In order to fix easily code style convention, many bundles now use PHP-CS-Fixer.

The .php_cs file allow configuration on your needs, actually i've include the same as Sonata Project.

The use is really simple, when you're developing, type make cs or make cs_dry_run, thanks to Makefile, he will correct all the files with defined rules.

The actual configuration manage, too automatically, headers files of the bundle.

If this solution concurs for you, you're free to modify after merge the configuration.

Cheers 🍻

[DavidBadura]

the change assertEquals to assertSame breaks the build.

[OskarStark]

This is wrong

if we use the header, please move the author above the class name and check the other files

[Th3Mouk]

Ok

[Th3Mouk]

Yes the php_unit_strict change the assertTest, i just removed it

[Th3Mouk]

@DavidBadura @OskarStark Any other mistakes ?

[Th3Mouk]

@DavidBadura ok for merge ?

[OskarStark]

Looks ok to me 👍

[DavidBadura]

it looks good to me. the probleme is, after we merge this all other PR's have then merge conflicts. maybe we should wait here?

[Th3Mouk]

The solution is to merged with using 'my branch' and ignoring upstream changes (if they're only relative to CS) and at the end type make cs command then commit 😉

All bundles had this problem with old PR's, when they changes testing or coding styles, but it's a problem that the time doesn't solve.

[OskarStark]

btw i would keep the header the same everywhere and add special authors above the class declaration. otherwise anybody will have diffs, if he execute make cs...

what do you think?

[Th3Mouk]

@OskarStark in the header I put only the maintainer or co-funder, and yes special authors must be on the class declaration. The header is only relative to bundle licence. But isn't the case here in my memory

[OskarStark]

OK @Th3Mouk 👍

[smoench]

I would just prefer the PSR2_LEVEL. The SYMFONY_LEVEL has some fixers I don't like.

[smoench]

@Th3Mouk Could you please revert the changes from php-cs-fixer fix-run. I must add some changes to the header comment on my own and a git rebase would be easier. Thanks in advance.

[bendavies]

@smoench i'm going to pick this up. Do you have a preference of cs config?

[Th3Mouk]

As you want, i can modify too if necessary

[bendavies]

@Th3Mouk thanks!
if you could rebase on master and address the other comments that would great

[Th3Mouk]

@smoench @bendavies it seems good

[DavidBadura]

Thank you! :)