Add QA checks through PHPStan and Psalm #413

phansys · 2021-07-24T05:50:55Z

Depends on #414 and #415.

Changelog

### Fixed
- Return value at `TokenStorageUsernameCallable::__invoke()`.

### Changed
- Several docblock types detected by PHPStan.

To Do

Add missing hints;
Re-visit several generics;
Add a changelog note.;
Fix Psalm issues under tests/ directory.

FlintCIBot · 2021-07-24T05:53:50Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64084

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2021-07-24T05:59:38Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64085

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2021-07-24T13:22:31Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64088

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2021-07-24T14:50:17Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64090

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2021-07-24T21:32:11Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64104

This comment was posted by FlintCI. It can be disabled in the repository settings.

VincentLanglet · 2021-07-24T21:39:09Z

src/AuditReader.php

@@ -64,6 +64,9 @@ class AuditReader
     * Entity cache to prevent circular references.
     *
     * @var array
+     *
+     * @phpstan-template T of object


A template on a property seems weird, it's on the class or on a method generally.
All the @phpstan-template T of object might be moved to the class...

VincentLanglet · 2021-07-24T21:41:28Z

src/Collection/AuditedCollection.php

+ * @phpstan-template TKey
+ * @psalm-template TKey of array-key
+ * @psalm-template T


Why do you need different template for phpstan and psalm ?

It was copied from Collection.

FlintCIBot · 2021-07-24T22:01:07Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64105

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2021-07-24T22:18:36Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64106

This comment was posted by FlintCI. It can be disabled in the repository settings.

VincentLanglet · 2021-07-24T23:40:41Z

src/ChangedEntity.php

@@ -17,6 +17,8 @@ class ChangedEntity
 {
    /**
     * @var string
+     *
+     * @phpstan-var class-string<T> $className


Tu use T, u have to defining the template on the class, and not only the construct i think

FlintCIBot · 2021-07-25T02:15:39Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64108

This comment was posted by FlintCI. It can be disabled in the repository settings.

FlintCIBot · 2021-07-25T02:34:28Z

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/8593/analyses/64109

This comment was posted by FlintCI. It can be disabled in the repository settings.

SonataCI · 2021-09-11T14:10:28Z

Could you please rebase your PR and fix merge conflicts?

jordisala1991 · 2021-10-27T07:00:15Z

tests/BaseTest.php

@@ -34,6 +35,8 @@ abstract class BaseTest extends TestCase
    protected static $conn;

    /**
+     * NEXT_MAJOR: Use `\Doctrine\ORM\EntityManagerInterface` instead.


This is a test class, cant it be changes right away?

No, because the real classes are using EntityManager in its argument declarations.
By instance:

Parameter #1 $em of method SimpleThings\EntityAudit\AuditManager::createAuditReader() expects Doctrine\ORM\EntityManager, Doctrine\ORM\EntityManagerInterface given.

phansys · 2021-10-27T16:14:45Z

@jordisala1991, @franmomu; could you please review again?

jordisala1991 · 2021-10-27T16:21:05Z

composer.json

-        "symfony/phpunit-bridge": "^5.3 || ^6.0"
+        "symfony/http-kernel": "^4.4 || ^5.3 || ^6.0",
+        "symfony/phpunit-bridge": "^5.3 || ^6.0",
+        "symfony/security-core": "^4.4 || ^5.3 || ^6.0",


this is already on require section

Good catch. Removed.

jordisala1991 · 2021-10-27T16:21:15Z

composer.json

        "symfony/cache": "^4.4 || ^5.3 || ^6.0",
        "symfony/http-foundation": "^4.4 || ^5.3 || ^6.0",
-        "symfony/phpunit-bridge": "^5.3 || ^6.0"
+        "symfony/http-kernel": "^4.4 || ^5.3 || ^6.0",


this one too

jordisala1991 · 2021-10-28T06:02:43Z

composer.json

        "symfony/cache": "^4.4 || ^5.3 || ^6.0",
        "symfony/http-foundation": "^4.4 || ^5.3 || ^6.0",
-        "symfony/phpunit-bridge": "^5.3 || ^6.0"
+        "symfony/phpunit-bridge": "^5.3 || ^6.0",
+        "symfony/var-dumper": "^4.4 || ^5.2",


you should use 4.4 5.3 and 6.0. To be consistent with the other symfony dependencies.

src/EventListener/CreateSchemaListener.php

src/EventListener/LogRevisionsListener.php

jordisala1991 · 2021-10-28T14:03:36Z

Please remember to open the dev-kit PR to add psalm and phpstan @phansys

phansys force-pushed the phpstan branch from 4116fbe to e796f00 Compare July 24, 2021 05:53

phansys force-pushed the phpstan branch from 8dd3fb3 to 1d930ce Compare July 24, 2021 21:31

VincentLanglet reviewed Jul 24, 2021

View reviewed changes

phansys added the pedantic label Jul 25, 2021

SonataCI added the pending author label Sep 11, 2021

phansys force-pushed the phpstan branch from 09c5245 to 2babdf8 Compare October 24, 2021 02:47

SonataCI removed the pending author label Oct 24, 2021

phansys force-pushed the phpstan branch 7 times, most recently from ed43cd1 to f5c11b5 Compare October 24, 2021 22:54

phansys marked this pull request as ready for review October 24, 2021 22:58

phansys requested review from VincentLanglet, jordisala1991 and a team October 24, 2021 22:58

phansys added the minor label Oct 25, 2021

VincentLanglet previously approved these changes Oct 27, 2021

View reviewed changes

jordisala1991 reviewed Oct 27, 2021

View reviewed changes

phansys dismissed VincentLanglet’s stale review via 78f600e October 27, 2021 12:18

phansys force-pushed the phpstan branch from d599c6a to 28d4395 Compare October 27, 2021 12:49

phansys requested review from jordisala1991 and VincentLanglet October 27, 2021 12:52

VincentLanglet previously approved these changes Oct 27, 2021

View reviewed changes

jordisala1991 reviewed Oct 27, 2021

View reviewed changes

phansys dismissed VincentLanglet’s stale review via 7ad701f October 27, 2021 17:08

phansys requested a review from jordisala1991 October 27, 2021 17:09

VincentLanglet previously approved these changes Oct 27, 2021

View reviewed changes

jordisala1991 reviewed Oct 28, 2021

View reviewed changes

franmomu reviewed Oct 28, 2021

View reviewed changes

src/EventListener/CreateSchemaListener.php Outdated Show resolved Hide resolved

src/EventListener/LogRevisionsListener.php Outdated Show resolved Hide resolved

phansys dismissed VincentLanglet’s stale review via 56a8e20 October 28, 2021 12:20

phansys force-pushed the phpstan branch 3 times, most recently from 93c23c7 to e282775 Compare October 28, 2021 12:45

phansys requested review from franmomu and jordisala1991 October 28, 2021 12:48

jordisala1991 previously approved these changes Oct 28, 2021

View reviewed changes

VincentLanglet previously approved these changes Oct 28, 2021

View reviewed changes

Add QA checks through PHPStan and Psalm

80e4638

phansys dismissed stale reviews from VincentLanglet and jordisala1991 via 80e4638 October 28, 2021 13:42

phansys force-pushed the phpstan branch from e282775 to 80e4638 Compare October 28, 2021 13:42

phansys merged commit e22914a into sonata-project:1.x Oct 28, 2021

phansys deleted the phpstan branch October 28, 2021 13:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add QA checks through PHPStan and Psalm #413

Add QA checks through PHPStan and Psalm #413

phansys commented Jul 24, 2021 •

edited

Loading

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

VincentLanglet Jul 24, 2021

VincentLanglet Jul 24, 2021

phansys Jul 25, 2021

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

VincentLanglet Jul 24, 2021

FlintCIBot commented Jul 25, 2021

FlintCIBot commented Jul 25, 2021

SonataCI commented Sep 11, 2021

jordisala1991 Oct 27, 2021

phansys Oct 27, 2021

phansys commented Oct 27, 2021

jordisala1991 Oct 27, 2021

phansys Oct 27, 2021

jordisala1991 Oct 27, 2021

jordisala1991 Oct 28, 2021

jordisala1991 commented Oct 28, 2021

Add QA checks through PHPStan and Psalm #413

Add QA checks through PHPStan and Psalm #413

Conversation

phansys commented Jul 24, 2021 • edited Loading

Changelog

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FlintCIBot commented Jul 24, 2021

FlintCIBot commented Jul 24, 2021

Choose a reason for hiding this comment

FlintCIBot commented Jul 25, 2021

FlintCIBot commented Jul 25, 2021

SonataCI commented Sep 11, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phansys commented Oct 27, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jordisala1991 commented Oct 28, 2021

phansys commented Jul 24, 2021 •

edited

Loading