Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "diff" result for dates and other objects #599

Merged
merged 5 commits into from
Jan 22, 2024
Merged

Fix "diff" result for dates and other objects #599

merged 5 commits into from
Jan 22, 2024

Commits on Jan 12, 2024

  1. Added tests for ArrayDiff. The test comparing dates and other objects… 

    … currently fail, because the strict comparison is used.
    @befresh-mweimerskirch
    befresh-mweimerskirch committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    36a8a71 View commit details
    Browse the repository at this point in the history

  2. If the values are objects, we will compare them by their properties. 

    This is necessary because the strict comparison operator (===) will return false if the objects are not the same instance.
    @befresh-mweimerskirch
    befresh-mweimerskirch committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    283df18 View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review 

    Co-authored-by: Javier Spagnoletti <[email protected]>
    @befresh-mweimerskirch @phansys
    befresh-mweimerskirch and phansys authored Jan 12, 2024
    Configuration menu
    Copy the full SHA
    0e16a9b View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. ArrayDiff: Added a test case with the same date but a different timez… 

    …one.
    @befresh-mweimerskirch
    befresh-mweimerskirch committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    38d0e80 View commit details
    Browse the repository at this point in the history

  2. Explained how the compareObjects method is different from using "==".

    @befresh-mweimerskirch
    befresh-mweimerskirch committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    ffd96e7 View commit details
    Browse the repository at this point in the history