Fix errors in composer container page #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordisala1991
commented
Sep 30, 2022
jordisala1991
force-pushed
the
hotfix/fix-parent-child-block-relation
branch
from
a444b96
to
84a2b84
Compare
jordisala1991
commented
Sep 30, 2022
|
I am trying an alternative for: #1611 Wip atm. |
jordisala1991
force-pushed
the
hotfix/fix-parent-child-block-relation
branch
from
50f4dcf
to
6f96017
Compare
jordisala1991
commented
Oct 1, 2022
| if (false !== $isComposer) { | ||
| $form->add('enabled', HiddenType::class, ['data' => true]); | ||
| } else { | ||
| $form->add('enabled'); | ||
| } | ||
|
|
||
| $form->end(); | ||
|
|
There was a problem hiding this comment.
Is better this way, this looks more similar to what we do on shared blocks.
jordisala1991
commented
Oct 1, 2022
| ->add('type', ServiceListType::class, ['context' => 'sonata_page_bundle']) | ||
| ->add('enabled') | ||
| ->add('position', IntegerType::class) | ||
| ->add('type', ServiceListType::class, ['context' => 'sonata_page_bundle']) |
There was a problem hiding this comment.
missing indentation. better to code readability.
jordisala1991
commented
Oct 1, 2022
jordisala1991
commented
Oct 1, 2022
jordisala1991
commented
Oct 1, 2022
jordisala1991
force-pushed
the
hotfix/fix-parent-child-block-relation
branch
from
92ca695
to
66b6a1e
Compare
|
Could you please rebase your PR and fix merge conflicts? |
jordisala1991
force-pushed
the
hotfix/fix-parent-child-block-relation
branch
from
66b6a1e
to
c313f4e
Compare
VincentLanglet
approved these changes
Oct 4, 2022
|
Ready to merge @jordisala1991 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subject
I am targeting this branch, because this is a problem for 4.0, since some blocks were removed.
Closes #1611
Changelog