DASH scale requirement update #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduced eni count from 64 to 32 increased CPS from 1.5M to 3.75
updated scale numbers for hero test based on HLD increased the flow timer to 5 sec
prsunny
approved these changes
Jul 18, 2023
|
Will cover in DASH community call, then sign-off/merge |
budgrise
reviewed
Jul 19, 2023
| @@ -204,7 +204,7 @@ integrators to track and test the designs in a common manner. | |||
| seen that meets the policy for the bi-directional flow setup. | |||
| When using this in CPS testing, we will send a total of 6 | |||
| packets to match TCP to make things more balanced. UDP | |||
| bi-directional flows will be aged within 1 second after | |||
| bi-directional flows will be aged within 5 second after | |||
| receiving the last packet. I would set all UDP bi-directional | |||
There was a problem hiding this comment.
Should the last sentence be removed ("0.5 - 1.0 second aging")?
There was a problem hiding this comment.
corrected to 5 seconds
There was a problem hiding this comment.
LGTM, thank you Mircea for changing ENI to 32 and CPS to 3M.
budgrise
reviewed
Jul 19, 2023
|
|
||
| - All TCP connections should be deleted from the table after the | ||
| test completes. | ||
|
|
||
| - The connection table should therefore be zero. | ||
|
|
||
| - All UDP bi-directional flows need to age out before the 1 second | ||
| - All UDP bi-directional flows need to age out before the 5 second | ||
| interval to allow for new UDP bi-directional flows to be | ||
| established. If everything works as advertised, we should never | ||
| see the connection table go above the 8M connections. If we do |
There was a problem hiding this comment.
Should "8M" be replaced with a different number?
There was a problem hiding this comment.
corrected to 32M flows or maybe it should be 15M only
budgrise
reviewed
Jul 19, 2023
| @@ -193,7 +193,7 @@ integrators to track and test the designs in a common manner. | |||
| expect more TCP and in fact in some cases we meter UDP as a | |||
| potential source of DoS. | |||
|
|
|||
| - Connection aging set to 1 sec and requires each connection or | |||
| - Connection aging set to 5 sec and requires each connection or | |||
| bi-directional flow to receive one packet every second in each | |||
There was a problem hiding this comment.
Should this say "receive one packet every 5 seconds" ?
There was a problem hiding this comment.
corrected to 4.9 sec as long as the packet is received right before the 5s mark flow should remain active
|
/easycla |
8M replaced with 32M 0.5- 1 second replaced with 5 seconds one packet every second replaced with 1 packet every 4.9 sec
| @@ -120,7 +120,7 @@ Following are the minimal scaling requirements | |||
| | Active Connections/ENI | 1M (Bidirectional TCP or UDP) | | |||
| | Total active connections | 32M (Bidirectional) | | |||
| | Metering Buckets per ENI | 4000 | | |||
| | CPS | 1.5M | | |||
| | CPS | 3.75M | | |||
There was a problem hiding this comment.
Suggested change
| | CPS | 3.75M | | |
| | CPS | 3.M | |
| | ACLs Ports | 10x10K | 3.2M | 6.4M | 12.8M | 25.6M | | ||
| | Mappings (CA to PA) | NA[^1] | 10M | 20M | 40M | 80M | | ||
| | Act Con | 1M | 32M[^2] | 64M | 128M | 256M | | ||
| | CPS | | 3.75M | 7.5M | 15M | 30M | |
There was a problem hiding this comment.
Suggested change
| | CPS | | 3.75M | 7.5M | 15M | 30M | | |
| | CPS | | 3M | 6M | 12M | 24M | |
vikumarks
added a commit
to vikumarks/msfthero
that referenced
this pull request
Jul 27, 2023
|
Per Community Call, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENIs per 200G link reduced to 32 from 64
adjusted CPS value in HLD to match the hero test
increased flow timer from 1 sec to 5 sec ( to reduce PPS requirements for BG traffic)