[Mellanox] enlarge the eeprom ready timeout from 20 to 60 #18983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keboliu
approved these changes
May 17, 2024
|
/azpw ms_conflict |
|
Hi @prgeor , could you please help review? |
|
@Junchao-Mellanox this is to confirm that this is a delay only during init, right? |
Yes. It will wait only if the file does not exit. The file is created during init by udev event sent from driver. |
liat-grozovik
approved these changes
May 29, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
May 30, 2024
…18983) - Why I did it Service like ZTP accesses EEPROM very early at the boot stage. It could cause an issue that EEPROM is not ready. The PR enlarge EEPROM ready timeout from 20s to 60s. - How I did it Enlarge EEPROM ready timeout from 20s to 60s. - How to verify it Manual test
|
Cherry-pick PR to 202311: #19143 |
mssonicbld
pushed a commit
that referenced
this pull request
May 31, 2024
- Why I did it Service like ZTP accesses EEPROM very early at the boot stage. It could cause an issue that EEPROM is not ready. The PR enlarge EEPROM ready timeout from 20s to 60s. - How I did it Enlarge EEPROM ready timeout from 20s to 60s. - How to verify it Manual test
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Junchao-Mellanox
added a commit
to Junchao-Mellanox/sonic-buildimage
that referenced
this pull request
Jul 29, 2024
…18983) - Why I did it Service like ZTP accesses EEPROM very early at the boot stage. It could cause an issue that EEPROM is not ready. The PR enlarge EEPROM ready timeout from 20s to 60s. - How I did it Enlarge EEPROM ready timeout from 20s to 60s. - How to verify it Manual test
12 tasks
|
@StormLiangMS for the 202305 PR. |
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 2, 2024
…19728) - Why I did it Service like ZTP accesses EEPROM very early at the boot stage. It could cause an issue that EEPROM is not ready. The PR enlarge EEPROM ready timeout from 20s to 60s. - How I did it Enlarge EEPROM ready timeout from 20s to 60s. - How to verify it Manual test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Service like ZTP accesses EEPROM very early at the boot stage. It could cause an issue that EEPROM is not ready. The PR enlarge EEPROM ready timeout from 20s to 60s.
Work item tracking
How I did it
Enlarge EEPROM ready timeout from 20s to 60s.
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)