[syncd] warn shutdown syncd process when warm boot is enabled #2078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <[email protected]>
Signed-off-by: Ying Xie <[email protected]>
kcudnik
approved these changes
Oct 1, 2018
jipanyang
approved these changes
Oct 1, 2018
judyjoseph
added a commit
that referenced
this pull request
Mar 20, 2022
9968d60 (HEAD -> 202111, origin/202111) [sonic-package-manager] do not mod_config for whole config db when setting init_cfg (#2055) 4b3d53f [generate_dump] exclude mft and mlx folders from /etc (#2072) 51d92ae Validation check correction while adding a member to PortChannel (#2078) 6a43306 [techsupport] Added a lock to avoid running techsupport in parallel (#2065) 44cfdd9 Try get port operational speed from STATE DB (#2030) 45ea623 Fix sonic-installer failure due to missing import
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
…ic-net#2078) Corrected the validation check while adding a member to a PortChannel This PR will fix the issue - sonic-net#9908 The CLI command should reject when trying to add member to a Portchannel when link-local is enabled in it. `` root@sonic:/home/admin# config ipv6 enable link-local root@sonic:/home/admin# root@sonic:/home/admin# config portchannel add PortChannel0001 root@sonic:/home/admin# root@sonic:/home/admin# config portchannel member add PortChannel0001 Ethernet64 Usage: config portchannel member add [OPTIONS] <portchannel_name> <port_name> Try "config portchannel member add -h" for help. Error: Ethernet64 has ip address configured root@sonic:/home/admin# `` Signed-off-by: Akhilesh Samineni [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ying Xie [email protected]
- What I did
When syncd service is stopping during warm reboot. Give syncd enough time to gracefully shutdown and save states.
- How to verify it
Set global warm shutdown flag, shutdown syncd service, make sure that the SAI state has been saved to specified file.
(However, full verification will have to wait until warm recover is in place).
Also what missing from this PR is definition of follow sample entries in sai.profile:
SAI_WARM_BOOT_READ_FILE=/var/warmboot/sai-warmboot.bin
SAI_WARM_BOOT_WRITE_FILE=/var/warmboot/sai-warmboot.bin