Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[device/celestica]: DX010 platform API update #4608

Merged
merged 4 commits into from
May 22, 2020

Conversation

mudsut4ke
Copy link
Contributor

- Why I did it

  • Various fixes and improvement

- How I did it

  • Fix fancontrol.service path
  • Fix return temp format in thermal API
  • Improve init time in chassis API
  • Upgrade sfp API

- How to verify it

@mudsut4ke
Copy link
Contributor Author

@pphuchar , Can you help review this ?

@lgtm-com
Copy link

lgtm-com bot commented May 15, 2020

This pull request introduces 16 alerts and fixes 9 when merging 8249172 into d90fdbf - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 6 for Unused import
  • 4 for Unused local variable

fixed alerts:

  • 4 for Unused import
  • 4 for Wrong number of arguments in a class instantiation
  • 1 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented May 18, 2020

This pull request introduces 16 alerts and fixes 9 when merging 3251932 into af95d57 - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'
  • 6 for Unused import
  • 4 for Unused local variable

fixed alerts:

  • 4 for Unused import
  • 4 for Wrong number of arguments in a class instantiation
  • 1 for Except block handles 'BaseException'

@lgtm-com
Copy link

lgtm-com bot commented May 18, 2020

This pull request introduces 6 alerts and fixes 9 when merging 6d308c9 into af95d57 - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'

fixed alerts:

  • 4 for Unused import
  • 4 for Wrong number of arguments in a class instantiation
  • 1 for Except block handles 'BaseException'

@mudsut4ke mudsut4ke marked this pull request as ready for review May 19, 2020 07:12
@lguohan lguohan requested a review from jleveque May 21, 2020 03:43
@jleveque
Copy link
Contributor

Wait for review from @pphuchar.

@mudsut4ke
Copy link
Contributor Author

@jleveque , Please also help add tag for merge this change to 201911 branch

@lguohan lguohan merged commit 5e5e9ec into sonic-net:master May 22, 2020
@abdosi
Copy link
Contributor

abdosi commented May 28, 2020

@mudsut4ke Please create seprate PR for 201911. There are conflicts.

@rlhui

@mudsut4ke
Copy link
Contributor Author

@abdosi , OK

mudsut4ke pushed a commit to mudsut4ke/sonic-buildimage that referenced this pull request Sep 21, 2020
- Fix fancontrol.service path
- Fix return temp format in thermal API
- Improve init time in chassis API
- Upgrade sfp API
sujinmkang pushed a commit that referenced this pull request Sep 24, 2020
* [device/celestica]: DX010 platform API update (#4608)

- Fix fancontrol.service path
- Fix return temp format in thermal API
- Improve init time in chassis API
- Upgrade sfp API

* [device/celestica]: Update DX010 reboot cause API (#4678)

- Add more cases support in DX010 reboot cause API
    - Add Thermal Overload reboot cause support
    - Add new Watchdog reboot cause support

* [device/celestica]: using sonic-py-common package
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants