Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[device/celestica]: Update DX010 platform APIS on 201911 branch #5416

Merged
merged 3 commits into from
Sep 24, 2020
Merged

[device/celestica]: Update DX010 platform APIS on 201911 branch #5416

merged 3 commits into from
Sep 24, 2020

Conversation

mudsut4ke
Copy link
Contributor

@mudsut4ke mudsut4ke commented Sep 21, 2020 •
edited
Loading

- Why I did it

  • Integrate DX010 platform API update from master to on 201911 branch

- How I did it

- How to verify it

  • Run show platform commands

- Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006

- Test log

Wirut Getbamrung added 2 commits September 21, 2020 14:49
[device/celestica]: DX010 platform API update (sonic-net#4608)
9b4a96c 
- Fix fancontrol.service path
- Fix return temp format in thermal API
- Improve init time in chassis API
- Upgrade sfp API
[device/celestica]: Update DX010 reboot cause API (sonic-net#4678)
4389b9d 
- Add more cases support in DX010 reboot cause API
    - Add Thermal Overload reboot cause support
    - Add new Watchdog reboot cause support
@lgtm-com
Copy link

lgtm-com bot commented Sep 21, 2020

This pull request introduces 6 alerts and fixes 12 when merging 4389b9d into bb41312 - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'

fixed alerts:

  • 5 for Unused import
  • 4 for Wrong number of arguments in a class instantiation
  • 1 for Module imports itself
  • 1 for Except block handles 'BaseException'
  • 1 for Variable defined multiple times

@mudsut4ke
Copy link
Contributor Author

retest broadcom please

@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2020

This pull request introduces 6 alerts and fixes 12 when merging e9148ee into a637c7f - view on LGTM.com

new alerts:

  • 6 for Except block handles 'BaseException'

fixed alerts:

  • 5 for Unused import
  • 4 for Wrong number of arguments in a class instantiation
  • 1 for Module imports itself
  • 1 for Except block handles 'BaseException'
  • 1 for Variable defined multiple times

@mudsut4ke mudsut4ke marked this pull request as ready for review September 24, 2020 12:55
@sujinmkang sujinmkang merged commit 10534a3 into sonic-net:201911 Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujinmkang sujinmkang sujinmkang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mudsut4ke @sujinmkang