Reland 'Make changes to building and packaging sairedis (#1116)' #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)' * Make changes to building and packaging sairedis This commit includes the following changes: 1. Use Debian build profiles instead of custom build targets to build different configurations of sairedis. Build profiles were designed for this purpose. This also makes the debian/rules file a bit cleaner. 2. Rely on the debug packages being automatically created, instead of us explicitly specifying it in debian/control. 3. Add actual support for excluding Python 2 binding during build. 4. Make sure the compile flags used for building Python 2 and Python 3 are actually correct. Signed-off-by: Saikrishna Arcot <[email protected]> * Update pipeline file Signed-off-by: Saikrishna Arcot <[email protected]> * Fix argument for profile Signed-off-by: Saikrishna Arcot <[email protected]> * Exclude libsai package from the list of dependencies Signed-off-by: Saikrishna Arcot <[email protected]> * Allow multiple syslog artifacts during tests Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
|
@qiluo-msft @kcudnik could you review this when you get a chance? |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Mar 9, 2023
|
/azp run Azure.sonic-sairedis |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Saikrishna Arcot <[email protected]>
|
@kcudnik Can you review this when you get a chance? |
kcudnik
reviewed
Jun 29, 2023
|
|
||
| AC_PATH_PROGS(SWIG, [swig3.0 swig]) | ||
|
|
||
| CXXFLAGS_COMMON="" | ||
| CXXFLAGS_COMMON+=" -ansi" | ||
| CXXFLAGS_COMMON+=" -fPIC" | ||
| CXXFLAGS_COMMON+=" -pipe" |
There was a problem hiding this comment.
why this is added? something wrong with temporary files ?
There was a problem hiding this comment.
Hmm, I don't remember why I added this. At best, this might give a bit of performance/space benefit since intermediate files will all get transferred in memory rather than needing to be saved to a file first. Using temporary files shouldn't cause any issue, unless disk space on /tmp is very low.
kcudnik
approved these changes
Jun 29, 2023
saiarcot895
added a commit
to saiarcot895/sonic-swss-common
that referenced
this pull request
Jun 30, 2023
The build rules for sairedis have been simplified in sonic-net/sonic-sairedis#1194. As a result, build targets have changed. Update the build step here accordingly. Signed-off-by: Saikrishna Arcot <[email protected]>
kcudnik
pushed a commit
that referenced
this pull request
Jul 4, 2023
This PR contains a fix of CodeQL bug introduced by: #1194 Signed-off-by: Nazarii Hnydyn <[email protected]>
saiarcot895
added a commit
to saiarcot895/sonic-sairedis
that referenced
this pull request
Jul 26, 2023
PR sonic-net#1194 removed the .ONESHELL flag (causing all commands for a target to be executed in a single shell environment). Because of that, multi-line shell code blocks aren't parsed correctly. Since the `syncd_init_common.sh` file should always exist anyways (it's unconditionally sourced by an init script and a start script), remove the if-check around it, and always run `sed` when building rpc packages. Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
added a commit
that referenced
this pull request
Jul 31, 2023
PR #1194 removed the .ONESHELL flag (causing all commands for a target to be executed in a single shell environment). Because of that, multi-line shell code blocks aren't parsed correctly. Since the `syncd_init_common.sh` file should always exist anyways (it's unconditionally sourced by an init script and a start script), remove the if-check around it, and always run `sed` when building rpc packages. Signed-off-by: Saikrishna Arcot <[email protected]> Co-authored-by: xumia <[email protected]>
saiarcot895
added a commit
to saiarcot895/sonic-sairedis
that referenced
this pull request
Jan 11, 2024
This fixes a breakage from sonic-net#1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure. Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
added a commit
that referenced
this pull request
Jan 12, 2024
This fixes a breakage from #1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure. Signed-off-by: Saikrishna Arcot <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-sairedis
that referenced
this pull request
Feb 2, 2024
This fixes a breakage from sonic-net#1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure. Signed-off-by: Saikrishna Arcot <[email protected]>
mssonicbld
pushed a commit
that referenced
this pull request
Feb 10, 2024
This fixes a breakage from #1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure. Signed-off-by: Saikrishna Arcot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vstest issues causing random test failures have since been fixed, and were not related to the changes in this PR.
This commit includes the following changes:
Signed-off-by: Saikrishna Arcot [email protected]
Signed-off-by: Saikrishna Arcot [email protected]
Signed-off-by: Saikrishna Arcot [email protected]
Signed-off-by: Saikrishna Arcot [email protected]
Signed-off-by: Saikrishna Arcot [email protected]
Microsoft ADO: 24405994