-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland 'Make changes to building and packaging sairedis (#1116)' #1194
Merged
saiarcot895
merged 4 commits into
sonic-net:master
from
saiarcot895:reland-build-packaging-changes
Jun 30, 2023
Merged
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
962d841
Reland 'Make changes to building and packaging sairedis (#1116)'
saiarcot895 d5da900
Fix debug poackage name in dockerfile
saiarcot895 f5730f4
Merge remote-tracking branch 'origin/master' into reland-build-packag…
saiarcot895 f6603d4
Fix armhf build due to python binary not existing
saiarcot895 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
10 | ||
12 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,24 +2,33 @@ Source: sonic | |
Maintainer: Kamil Cudnik <[email protected]> | ||
Section: net | ||
Priority: optional | ||
Build-Depends: debhelper (>=9), autotools-dev, libzmq5-dev | ||
Build-Depends: debhelper (>= 12), autotools-dev, libzmq5-dev | ||
Standards-Version: 1.0.0 | ||
|
||
Package: syncd | ||
Architecture: any | ||
Build-Profiles: <syncd !rpc !vs> | ||
Depends: ${misc:Pre-Depends} | ||
Recommends: ${shlibs:Depends} | ||
Conflicts: syncd-rpc, syncd-vs | ||
Description: This package contains sync daemon for SONiC project. | ||
This sync daemon syncs the ASIC_DB in Redis database and the real ASIC via SAI. | ||
|
||
Package: syncd-rpc | ||
Architecture: any | ||
Build-Profiles: <syncd rpc !vs> | ||
Depends: ${misc:Pre-Depends} | ||
Recommends: ${shlibs:Depends} | ||
Conflicts: syncd, syncd-vs | ||
Description: This package contains sync daemon with rpc for SONiC project. | ||
This sync daemon syncs the ASIC_DB in Redis database and the real ASIC via SAI. | ||
This daemon contains saithrift rpc library for remote control of an ASIC. | ||
|
||
Package: syncd-vs | ||
Architecture: any | ||
Build-Profiles: <syncd !rpc vs> | ||
Depends: ${misc:Pre-Depends} | ||
Recommends: ${shlibs:Depends} | ||
Conflicts: syncd-rpc, syncd | ||
Description: This package contains sync daemon for SONiC project linked with virtual switch. | ||
This sync daemon syncs the ASIC_DB in Redis database and the real ASIC via SAI. | ||
|
@@ -38,6 +47,7 @@ Description: This package contains development files for SAI-Redis. | |
|
||
Package: libsaivs | ||
Architecture: any | ||
Depends: ${shlibs:Depends}, ${misc:Pre-Depends} | ||
Section: libs | ||
Description: This package contains SAI-VirtualSwitch implementation for SONiC project. | ||
|
||
|
@@ -49,6 +59,7 @@ Description: This package contains development files for SAI-VirtualSwitch. | |
|
||
Package: libsaimetadata | ||
Architecture: any | ||
Depends: ${shlibs:Depends}, ${misc:Pre-Depends} | ||
Section: libs | ||
Description: This package contains SAI-Metadata implementation for SONiC project. | ||
|
||
|
@@ -58,63 +69,6 @@ Depends: libsaimetadata (= ${binary:Version}) | |
Section: libdevel | ||
Description: This package contains development files for SAI-Metadata. | ||
|
||
Package: syncd-dbg | ||
Architecture: any | ||
Section: debug | ||
Priority: extra | ||
Conflicts: syncd-rpc-dbg, syncd-vs | ||
Depends: | ||
syncd (= ${binary:Version}), | ||
${misc:Depends} | ||
Description: debugging symbols for syncd | ||
|
||
Package: syncd-rpc-dbg | ||
Architecture: any | ||
Section: debug | ||
Priority: extra | ||
Conflicts: syncd-dbg, syncd-vs | ||
Depends: | ||
syncd-rpc (= ${binary:Version}), | ||
${misc:Depends} | ||
Description: debugging symbols for syncd-rpc | ||
|
||
Package: syncd-vs-dbg | ||
Architecture: any | ||
Section: debug | ||
Priority: extra | ||
Conflicts: syncd-dbg, syncd-rpc-dbg | ||
Depends: | ||
syncd-vs (= ${binary:Version}), | ||
${misc:Depends} | ||
Description: debugging symbols for syncd-vs | ||
|
||
Package: libsairedis-dbg | ||
Architecture: any | ||
Section: debug | ||
Priority: extra | ||
Depends: | ||
libsairedis (= ${binary:Version}), | ||
${misc:Depends} | ||
Description: debugging symbols for libsairedis | ||
|
||
Package: libsaivs-dbg | ||
Architecture: any | ||
Section: debug | ||
Priority: extra | ||
Depends: | ||
libsaivs (= ${binary:Version}), | ||
${misc:Depends} | ||
Description: debugging symbols for libsaivs | ||
|
||
Package: libsaimetadata-dbg | ||
Architecture: any | ||
Section: debug | ||
Priority: extra | ||
Depends: | ||
libsaimetadata (= ${binary:Version}), | ||
${misc:Depends} | ||
Description: debugging symbols for libsaimetadata | ||
|
||
Package: python-pysairedis | ||
Architecture: any | ||
Build-Profiles: <!nopython2> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
meta/sai*.h usr/include/sai | ||
meta/Sai*.h usr/include/sai | ||
SAI/meta/sai*.h usr/include/sai | ||
usr/lib/*/libsaimetadata.so | ||
kcudnik marked this conversation as resolved.
Show resolved
Hide resolved
|
||
usr/lib/*/libsaimeta.so |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,2 @@ | ||
lib/sairedis.h usr/include/sai | ||
usr/lib/*/libsairedis.so |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this is added? something wrong with temporary files ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I don't remember why I added this. At best, this might give a bit of performance/space benefit since intermediate files will all get transferred in memory rather than needing to be saved to a file first. Using temporary files shouldn't cause any issue, unless disk space on
/tmp
is very low.