Switch to using stock gcovr 5.2 #726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]>
This is to work around gcovr/gcovr#627. This error popped up during the CI run: ``` gcovr.gcov_parser.UnknownLineType: function swss::Select::~Select() called 377 returned NAN % blocks executed 100% ``` Signed-off-by: Saikrishna Arcot <[email protected]>
xumia
approved these changes
Dec 23, 2022
prsunny
approved these changes
Dec 23, 2022
|
@saiarcot895 , could you please make this change for sonic-swss as well? |
|
@prsunny, it doesn't look like sonic-swss is using this custom repo. |
|
202205 breaks for this issue. |
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-swss-common
that referenced
this pull request
Dec 27, 2022
* Switch to using stock gcovr 5.2 The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]>
liushilongbuaa
added a commit
that referenced
this pull request
Dec 28, 2022
* Switch to using stock gcovr 5.2 (#726) The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]> * Fix sonic-slave docker image environment issue. Signed-off-by: shilongliu <[email protected]>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-swss-common
that referenced
this pull request
Dec 28, 2022
* Switch to using stock gcovr 5.2 The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]>
liushilongbuaa
added a commit
that referenced
this pull request
Dec 29, 2022
* Switch to using stock gcovr 5.2 The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]> Signed-off-by: Saikrishna Arcot <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]>
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-swss-common
that referenced
this pull request
Dec 29, 2022
* Switch to using stock gcovr 5.2 The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]>
liushilongbuaa
added a commit
that referenced
this pull request
Jan 3, 2023
* Switch to using stock gcovr 5.2 (#726) * Switch to using stock gcovr 5.2 The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]> * Fix: missing sonic-db-cli in docker-sonic-vs image (#640) * Purge package sonic-db-cli which depends on libswsscommon (#628) Since sonic-db-cli depends on libswsscommon, we could not simply only purge libswsscommon, so we purge both together. The build error is as below Step 8/19 : RUN dpkg --purge libswsscommon ---> Running in ed8132d457e9 dpkg: dependency problems prevent removal of libswsscommon: sonic-db-cli depends on libswsscommon. dpkg: error processing package libswsscommon (--purge): dependency problems - not removing Errors were encountered while processing: libswsscommon Signed-off-by: Saikrishna Arcot <[email protected]> Co-authored-by: Saikrishna Arcot <[email protected]> Co-authored-by: Qi Luo <[email protected]>
|
@saiarcot895 this change cannot be cherry-picked cleanly to 202205 branch. Please raise separate PR. |
|
It was manually cherry-picked in #728 by Shilong. I'll update the tags for the other branches. |
8 tasks
lguohan
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jan 8, 2023
9e1176d Zain Budhwani Fri Jan 6 09:00:11 2023 -0800 Refactor eventpublisher deinit (sonic-net/sonic-swss-common#734) b9a9dbb Liu Shilong Thu Jan 5 10:12:49 2023 +0800 Simplify azure pipeline build template (sonic-net/sonic-swss-common#729) 01fc252 siqbal1986 Wed Jan 4 11:03:53 2023 -0800 Added customer monitoring tables in app db and state db (sonic-net/sonic-swss-common#725) 28dc42a Liu Shilong Wed Dec 28 11:19:32 2022 +0800 Fix sonic-slave docker image environment issue. (sonic-net/sonic-swss-common#727) 1d7607a Saikrishna Arcot Fri Dec 23 11:11:33 2022 -0800 Switch to using stock gcovr 5.2 (sonic-net/sonic-swss-common#726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work.
Copied from sonic-net/sonic-sairedis#1174.
Signed-off-by: Saikrishna Arcot [email protected]