Switch to using stock gcovr 5.2 (#726) #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Switch to using stock gcovr 5.2 The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work. Signed-off-by: Saikrishna Arcot <[email protected]>
) Since sonic-db-cli depends on libswsscommon, we could not simply only purge libswsscommon, so we purge both together. The build error is as below Step 8/19 : RUN dpkg --purge libswsscommon ---> Running in ed8132d457e9 dpkg: dependency problems prevent removal of libswsscommon: sonic-db-cli depends on libswsscommon. dpkg: error processing package libswsscommon (--purge): dependency problems - not removing Errors were encountered while processing: libswsscommon
bingwang-ms
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom branch we were using previously has since been deleted. That branch appears to have some fix for searching for the source file (for a gcda file) recursively. I don't know if it's needed or not today, but using the stock gcovr 5.2 (from the official repo) appears to work.
Signed-off-by: Saikrishna Arcot [email protected]