Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-package-manager] first phase implementation of sonic-package-manager #1527

Merged
merged 54 commits into from
Apr 29, 2021

Conversation

stepanblyschak
Copy link
Contributor

What I did

Implemented sonic-package-manager utility to manager SONiC Packages as per HLD sonic-net/SONiC#682.
Implemented optional logic to migrate packages into new SONiC image in sonic-installer.

How I did it

Implemented as per HLD sonic-net/SONiC#682.

How to verify it

(Doc: sonic-net/SONiC#682)

  • install package
  • uninstall package
  • upgrade package
  • S2S upgrade

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyshchak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request introduces 2 alerts when merging f2ee39f into 1ee04fb - view on LGTM.com

new alerts:

  • 2 for Unused import

Signed-off-by: Stepan Blyschak <[email protected]>
@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request introduces 2 alerts when merging c724569 into 1ee04fb - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request introduces 2 alerts when merging 3dc793f into 1ee04fb - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Mar 25, 2021

This pull request introduces 2 alerts when merging faeadcf into 1ee04fb - view on LGTM.com

new alerts:

  • 2 for Unused import

Copy link
Contributor

@renukamanavalan renukamanavalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest of the review can be done during sub group meeting, with Stephan leading it.

doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Mar 29, 2021

This pull request introduces 2 alerts when merging ae1ce45 into 28b64ec - view on LGTM.com

new alerts:

  • 2 for Unused import

doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Outdated Show resolved Hide resolved
doc/Command-Reference.md Show resolved Hide resolved
sonic_installer/main.py Outdated Show resolved Hide resolved
sonic_installer/main.py Show resolved Hide resolved
@stepanblyschak
Copy link
Contributor Author

How are the docker image tags going to be used here? Maybe they should be shown instead or additionally to the "Version" ?
[SB] They are not displayed here, user can do "docker images" to see the tag

@liat-grozovik
Copy link
Collaborator

@renukamanavalan do we still have open issues following all the above fixes?

setup.py Outdated Show resolved Hide resolved
sonic_installer/bootloader/bootloader.py Outdated Show resolved Hide resolved
sonic_package_manager/manager.py Show resolved Hide resolved
sonic_package_manager/manifest.py Show resolved Hide resolved
sonic_package_manager/registry.py Show resolved Hide resolved
tests/sonic_package_manager/test_manager.py Show resolved Hide resolved
tests/sonic_package_manager/test_metadata.py Show resolved Hide resolved
tests/sonic_package_manager/test_reference.py Show resolved Hide resolved
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This is a large PR but the code is very clean, well-organized and easy to read. Thank you!

@renukamanavalan
Copy link
Contributor

Ready for merge. Waiting for build to complete.

@renukamanavalan renukamanavalan merged commit 08337aa into sonic-net:master Apr 29, 2021
gitsabari pushed a commit to gitsabari/sonic-utilities that referenced this pull request Jun 15, 2021
…anager (sonic-net#1527)

What I did
Implemented sonic-package-manager utility to manager SONiC Packages as per HLD sonic-net/SONiC#682.
Implemented optional logic to migrate packages into new SONiC image in sonic-installer.

How I did it
Implemented as per HLD sonic-net/SONiC#682.

How to verify it
(Doc: sonic-net/SONiC#682)

install package
uninstall package
upgrade package
S2S upgrade

THANK YOU, Stepan!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants