disk_check: Script updated #1747

renukamanavalan · 2021-08-07T04:46:39Z

What I did

Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name.
Adopt for older version of python3

How I did it

Changes:

Individual subdirs for each dir to be mounted
subprocess args made compatible with older version of python3 (tested in version 3.5.3)

How to verify it

Simulate read-only state
Run this script
Test ssh via new tacacs user (who had not logged in earlier)

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Changes: 1) Individual subdirs for each dir to be mounted 2) subprocess args to be in sync with python3 version in 201811 & 201911

lguohan · 2021-08-17T21:55:38Z

@qiluo-msft , can you take priority to review this one?

qiluo-msft · 2021-08-18T07:39:27Z

scripts/disk_check.py

    ret = proc.returncode
    if ret:
        log_err("failed: ret={} cmd={}".format(ret, cmd))
    else:
        log_info("ret={} cmd: {}".format(ret, cmd))

    if proc.stdout:
-        log_info("stdout: {}".format(str(proc.stdout)))
+        log_info("stdout: {}".format(proc.stdout.decode("utf-8")))


"utf-8"

You can use default parameter value. #WontFix

Prefer to keep it explicit. Any issue with that.

qiluo-msft · 2021-08-18T07:52:51Z

tests/disk_check_test.py

@@ -26,7 +27,7 @@
        "workdir": "/tmp/tmpy",
        "mounts": "overlay_tmpx blahblah",
        "err": "/tmpx is not read-write|READ-ONLY: Mounted ['/tmpx'] to make Read-Write",
-        "cmds": ['mount -t overlay overlay_tmpx -o lowerdir=/tmpx,upperdir=/tmp/tmpx,workdir=/tmp/tmpy /tmpx']
+        "cmds": ['mount -t overlay overlay_tmpx -o lowerdir=/tmpx,upperdir=/tmp/tmpx/tmpx,workdir=/tmp/tmpy/tmpx /tmpx']


upperdir=/tmp/tmpx/tmpx

Could you explain why you need test code change when you change implementation details? Could you make test code not depends on the implementation? #Closed

This is a base change. We use explicit subdir under upper & work for each dir to mount.

qiluo-msft

Could you refine the PR title (and the title during squash merge)? It is not clear what you plan to adopt? Audience know nothing about 201811/201911 adoption requirement. I guess you mean adapt code to be compatible with python2?

…1747) What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)

…ly (#1873) * disk_check: Check & mount RO as RW using tmpfs (#1569) What I did There is a bug that occasionally turn root-overlay as RO. This makes /etc & /home as RO. This blocks any new remote user login, as that needs to write into /etc & /home. This tool scans /etc & /home (or given dirs) as in RW or RO state. If RO, it could create a writable overlay using tmpfs. This is transient and stays until next reboot. Any write after the overlay will be lost upon reboot. But this allows new remote users login. How I did it Create upper & work dirs in /run/mount (tmpfs). Mount /etc & /home as lowerdirs and use the same name for final merge. This allows anyone opening a file in /etc or /home to operate on the merged overlay, transparently. How to verify it Mount any dir on tmpfs ( mount -t tmpfs tmpfs test_dir) remount as RO (mount -o remount,ro test_dir) Pass that dir to this script. (disk_check.py -d ./test_dir) Now it should be RW * disk_check updates: (#1736) 1) Set default loglevel to SYSLOG_ERR 2) Make log level configurable via args * disk_check: Script updated to run good in 201811 & 201911 (#1747) What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)

What I did Have independent subdirs for each mounted dir to avoid any collisions of files/dirs by same name. Adopt for older version of python3 How I did it Changes: Individual subdirs for each dir to be mounted subprocess args made compatible with older version of python3 (tested in version 3.5.3) How to verify it Simulate read-only state Run this script Test ssh via new tacacs user (who had not logged in earlier)

Submodule update for sonic-utilties ``` 48035d7 [202012] [techsupport] Techsupport Error Reporting pending fixes (sonic-net#1854) 8b2ec09 Fix log_ssd_health hang issue (sonic-net#1904) ac9c425 Fix the option missing in kernel config issue (sonic-net#1888) 5cc9417 disk_check: Script updated to run good in 201811 & 201911 (sonic-net#1747) ```

Script updated to un good in 201811 & 201911.

0e25151

Changes: 1) Individual subdirs for each dir to be mounted 2) subprocess args to be in sync with python3 version in 201811 & 201911

renukamanavalan added the Enhancement label Aug 7, 2021

renukamanavalan requested a review from lguohan August 7, 2021 04:46

renukamanavalan self-assigned this Aug 7, 2021

Added some comments.

7f7d5a4

renukamanavalan requested a review from qiluo-msft August 17, 2021 21:56

qiluo-msft reviewed Aug 18, 2021

View reviewed changes

qiluo-msft approved these changes Aug 24, 2021

View reviewed changes

renukamanavalan added Request for 201811 Branch Request for 201911 Branch labels Aug 24, 2021

renukamanavalan merged commit e12c1c8 into sonic-net:master Aug 24, 2021

renukamanavalan changed the title ~~disk_check: Script updated to run good in 201811 & 201911~~ disk_check: Script updated Aug 24, 2021

renukamanavalan mentioned this pull request Oct 11, 2021

disk_Check: Scan & mount as RW when disk turns into Read-only #1872

Merged

renukamanavalan mentioned this pull request Oct 11, 2021

[201811] disk_check.py: Allow remote user access when disk is read-only #1873

Merged

renukamanavalan added the Request for 202012 Branch label Oct 22, 2021

qiluo-msft added the Included in 202012 Branch label Oct 27, 2021

renukamanavalan mentioned this pull request Oct 28, 2021

disk_check: Collect system data on failure sonic-net/sonic-mgmt#4546

Closed

4 tasks

renukamanavalan deleted the disk_chk_log branch September 16, 2022 17:39

yxieca removed the Request for 201811 Branch label Oct 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

disk_check: Script updated #1747

disk_check: Script updated #1747

renukamanavalan commented Aug 7, 2021 •

edited

Loading

lguohan commented Aug 17, 2021

qiluo-msft Aug 18, 2021 •

edited

Loading

renukamanavalan Aug 18, 2021

qiluo-msft Aug 18, 2021 •

edited

Loading

renukamanavalan Aug 18, 2021

qiluo-msft left a comment

disk_check: Script updated #1747

disk_check: Script updated #1747

Conversation

renukamanavalan commented Aug 7, 2021 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

lguohan commented Aug 17, 2021

qiluo-msft Aug 18, 2021 • edited Loading

Choose a reason for hiding this comment

renukamanavalan Aug 18, 2021

Choose a reason for hiding this comment

qiluo-msft Aug 18, 2021 • edited Loading

Choose a reason for hiding this comment

renukamanavalan Aug 18, 2021

Choose a reason for hiding this comment

qiluo-msft left a comment

Choose a reason for hiding this comment

renukamanavalan commented Aug 7, 2021 •

edited

Loading

qiluo-msft Aug 18, 2021 •

edited

Loading

qiluo-msft Aug 18, 2021 •

edited

Loading