Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[202012] [techsupport] Techsupport Error Reporting pending fixes #1854

Merged
merged 8 commits into from
Nov 8, 2021

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Oct 3, 2021

What I did

This PR include some fixes which were missed while manually porting the error reporting PR onto 202012 #1833.

i.e. removing -it option from the docker exec commands. to understand why the -it option was removed, refer #1723

This also include another fix which removes -d from the show ip interface command, which fails otherwise.

Note: -d option for "show ip interface" is working on master and 202106. and not for 202012. So, this change is particular to 202012.

Master:

admin@sonic-master-imge:~$ show ip interfaces -d all
Interface        Master    IPv4 address/mask    Admin/Oper    BGP Neighbor    Neighbor IP
---------------  --------  -------------------  ------------  --------------  -------------
Loopback0                  10.1.0.32/32         up/up         N/A             N/A
PortChannel0001            10.0.0.56/31         up/up         ARISTA01T1      10.0.0.57
PortChannel0002            10.0.0.58/31         up/up         ARISTA02T1      10.0.0.59
PortChannel0003            10.0.0.60/31         up/up         ARISTA03T1      10.0.0.61
PortChannel0004            10.0.0.62/31         up/up         ARISTA04T1      10.0.0.63
Vlan1000                   192.168.0.1/21       up/up         N/A             N/A
docker0                    240.127.1.1/24       up/down       N/A             N/A
eth0                       10.75.206.180/24     up/up         N/A             N/A
lo                         127.0.0.1/16         up/up         N/A             N/A

202012:

admin@sonic-202012-image:~$ show ip interfaces -d all
Usage: show ip interfaces [OPTIONS]
Try "show ip interfaces -h" for help.

Error: no such option: -d

How I did it

How to verify it

  • Run the show tech-support and check the return status. It should be zero. (Atleast, it was on mellanox platform. I couldn't check the functions which were platform specific)
  • Run the "show techsupport" test.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Copy link
Contributor

@yxieca yxieca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make matching sonic-mgmt test_techsupport_commands() change.

Again, have you tested your change with the test mentioned above?

@vivekrnv
Copy link
Contributor Author

Please make matching sonic-mgmt test_techsupport_commands() change.

Again, have you tested your change with the test mentioned above?

Raised the changes to sonic-mgmt sonic-net/sonic-mgmt#4504

@liat-grozovik
Copy link
Collaborator

@qiluo-msft could you please help to merge?

@qiluo-msft qiluo-msft merged commit 48035d7 into sonic-net:202012 Nov 8, 2021
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
d29a49a [ACL] Match TCP protocol while matching TCP_FLAG (sonic-net#1854)
2569ad9 Fix sFlow sampling-rate and admin-state (sonic-net#1728)
8908a8f Change rif_rates.lua and port_rates.lua scripts to calculate rates correct (sonic-net#1848)
b42c2fb [VS Test] Skip flaky tests (sonic-net#1875)

Signed-off-by: bingwang <[email protected]>
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
Submodule update for sonic-utilties

```
48035d7 [202012] [techsupport] Techsupport Error Reporting pending fixes (sonic-net#1854)
8b2ec09 Fix log_ssd_health hang issue (sonic-net#1904)
ac9c425 Fix the option missing in kernel config issue (sonic-net#1888)
5cc9417 disk_check: Script updated to run good in 201811 & 201911 (sonic-net#1747)
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants