Ensure FlutterDesktopViewControllerState declares default destructor #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types containing std::unique_ptr to incomplete types require a destructor to be
defined as the size is unavailable, otherwise the following error is raised at
compile time:
/usr/lib/gcc/aarch64-linux-gnu/13/../../../../include/c++/13/bits/unique_ptr.h:97:16: error: invalid application of 'sizeof' to an incomplete type 'flutter::FlutterELinuxView'
91 | _GLIBCXX23_CONSTEXPR
92 | void
93 | operator()(_Tp* __ptr) const
| `- note: in instantiation of member function 'std::default_delete<flutter::FlutterELinuxView>::operator()' requested here
94 | {
95 | static_assert(!is_void<_Tp>::value,
96 | "can't delete pointer to incomplete type");
97 | static_assert(sizeof(_Tp)>0,
| `- error: invalid application of 'sizeof' to an incomplete type 'flutter::FlutterELinuxView'
98 | "can't delete pointer to incomplete type");
99 | delete __ptr;
Signed-off-by: Luke Howard <[email protected]>
HidenoriMatsubayashi
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
types containing std::unique_ptr to incomplete types require a destructor to be defined as the size is unavailable, otherwise the following error is raised at compile time: